git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>,
	Josh Triplett <josh@joshtriplett.org>,
	Thomas Rast <tr@thomasrast.ch>,
	Michael Haggerty <mhagger@alum.mit.edu>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Greg Kroah-Hartman <greg@kroah.com>, Jeff King <peff@peff.net>
Subject: [PATCH v2 15/16] trailer: set author and committer env variables
Date: Sun, 19 Jan 2014 09:53:53 +0100	[thread overview]
Message-ID: <20140119085355.2734.55181.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20140119083636.2734.14378.chriscool@tuxfamily.org>

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 trailer.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/trailer.c b/trailer.c
index 549d381..3b21f57 100644
--- a/trailer.c
+++ b/trailer.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "run-command.h"
+#include "argv-array.h"
 /*
  * Copyright (c) 2013 Christian Couder <chriscool@tuxfamily.org>
  */
@@ -415,14 +416,40 @@ static int read_from_command(struct child_process *cp, struct strbuf *buf)
 	return 0;
 }
 
+static void setup_ac_env(struct argv_array *env, const char *ac_name, const char *ac_mail, const char *(*read)(int))
+{
+	if (!getenv(ac_name) || !getenv(ac_mail)) {
+		struct ident_split ident;
+		const char *namebuf, *mailbuf;
+		int namelen, maillen;
+		const char *ac_info = read(IDENT_NO_DATE);
+
+		if (split_ident_line(&ident, ac_info, strlen(ac_info)))
+			return;
+
+		namelen = ident.name_end - ident.name_begin;
+		namebuf = ident.name_begin;
+
+		maillen = ident.mail_end - ident.mail_begin;
+		mailbuf = ident.mail_begin;
+
+		argv_array_pushf(env, "%s=%.*s", ac_name, namelen, namebuf);
+		argv_array_pushf(env, "%s=%.*s", ac_mail, maillen, mailbuf);
+	}
+}
+
 static const char *apply_command(const char *command, const char *arg)
 {
+	struct argv_array env = ARGV_ARRAY_INIT;
 	struct strbuf cmd = STRBUF_INIT;
 	struct strbuf buf = STRBUF_INIT;
 	struct child_process cp;
 	const char *argv[] = {NULL, NULL};
 	const char *result = "";
 
+	setup_ac_env(&env, "GIT_AUTHOR_NAME", "GIT_AUTHOR_EMAIL", git_author_info);
+	setup_ac_env(&env, "GIT_COMMITTER_NAME", "GIT_COMMITTER_EMAIL", git_committer_info);
+
 	strbuf_addstr(&cmd, command);
 	if (arg)
 		strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
@@ -430,7 +457,7 @@ static const char *apply_command(const char *command, const char *arg)
 	argv[0] = cmd.buf;
 	memset(&cp, 0, sizeof(cp));
 	cp.argv = argv;
-	cp.env = local_repo_env;
+	cp.env = env.argv;
 	cp.no_stdin = 1;
 	cp.out = -1;
 	cp.use_shell = 1;
@@ -441,6 +468,7 @@ static const char *apply_command(const char *command, const char *arg)
 		result = strbuf_detach(&buf, NULL);
 
 	strbuf_release(&cmd);
+	argv_array_clear(&env);
 	return result;
 }
 
-- 
1.8.5.2.201.gacc5987

  parent reply	other threads:[~2014-01-19  8:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-19  8:53 [PATCH v2 00/16] Add interpret-trailers builtin Christian Couder
2014-01-19  8:53 ` [PATCH v2 01/16] Add data structures and basic functions for commit trailers Christian Couder
2014-01-19  8:53 ` [PATCH v2 02/16] trailer: process trailers from file and arguments Christian Couder
2014-01-19  8:53 ` [PATCH v2 03/16] trailer: read and process config information Christian Couder
2014-01-19  8:53 ` [PATCH v2 04/16] trailer: process command line trailer arguments Christian Couder
2014-01-21 22:41   ` Junio C Hamano
2014-01-21 22:50     ` Junio C Hamano
2014-01-26 17:28       ` Christian Couder
2014-01-19  8:53 ` [PATCH v2 05/16] strbuf: add strbuf_isspace() Christian Couder
2014-01-19  8:53 ` [PATCH v2 06/16] trailer: parse trailers from input file Christian Couder
2014-01-19  8:53 ` [PATCH v2 07/16] trailer: put all the processing together and print Christian Couder
2014-01-19  8:53 ` [PATCH v2 08/16] trailer: add interpret-trailers command Christian Couder
2014-01-19  8:53 ` [PATCH v2 09/16] trailer: add tests for "git interpret-trailers" Christian Couder
2014-01-19  8:53 ` [PATCH v2 10/16] trailer: if no input file is passed, read from stdin Christian Couder
2014-01-19  8:53 ` [PATCH v2 11/16] trailer: add new_trailer_item() function Christian Couder
2014-01-19  8:53 ` [PATCH v2 12/16] strbuf: add strbuf_replace() Christian Couder
2014-01-19  8:53 ` [PATCH v2 13/16] trailer: execute command from 'trailer.<name>.command' Christian Couder
2014-01-19  8:53 ` [PATCH v2 14/16] trailer: add tests for trailer command Christian Couder
2014-01-19  8:53 ` Christian Couder [this message]
2014-01-19  8:53 ` [PATCH v2 16/16] trailer: add tests for commands using env variables Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140119085355.2734.55181.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=dan.carpenter@oracle.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=greg@kroah.com \
    --cc=johan@herland.net \
    --cc=josh@joshtriplett.org \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).