* What's cooking in git.git (Jan 2014, #03; Thu, 16) @ 2014-01-16 21:03 Junio C Hamano 2014-01-21 22:14 ` [ANNOUNCE] Git v1.9-rc0 Junio C Hamano 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-16 21:03 UTC (permalink / raw) To: git; +Cc: Pat Thoyts, Paul Mackerras, Eric Wong, Jiang Xin Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. I am planning to tag 1.9-rc0 preview release from the tip of 'master' soonish. Hopefully a few fix-up topics still in flight and also updates to git-gui, gitk, git-svn, i18n, etc. from respective area maintainers can be merged by the time 1.9-rc1 will be tagged. You can find the changes described here in the integration branches of the repositories listed at http://git-blame.blogspot.com/p/git-public-repositories.html -------------------------------------------------- [Graduated to "master"] * br/sha1-name-40-hex-no-disambiguation (2014-01-07) 1 commit (merged to 'next' on 2014-01-10 at 2a0973b) + sha1_name: don't resolve refs when core.warnambiguousrefs is false (this branch is used by jk/warn-on-object-refname-ambiguity.) When parsing a 40-hex string into the object name, the string is checked to see if it can be interpreted as a ref so that a warning can be given for ambiguity. The code kicked in even when the core.warnambiguousrefs is set to false to squelch this warning, in which case the cycles spent to look at the ref namespace were an expensive no-op, as the result was discarded without being used. * jk/pull-rebase-using-fork-point (2014-01-09) 1 commit (merged to 'next' on 2014-01-10 at e86e59d) + rebase: fix fork-point with zero arguments * jl/submodule-mv-checkout-caveat (2014-01-07) 2 commits (merged to 'next' on 2014-01-10 at 8d3953c) + rm: better document side effects when removing a submodule + mv: better document side effects when moving a submodule With a submodule that was initialized in an old fashioned way without gitlinks, switching branches in the superproject between the one with and without the submodule may leave the submodule working tree with its embedded repository behind, as there may be unexpendable state there. Document and warn users about this. * jn/pager-lv-default-env (2014-01-07) 1 commit (merged to 'next' on 2014-01-10 at 22d4755) + pager: set LV=-c alongside LESS=FRSX Just like we give a reasonable default for "less" via the LESS environment variable, specify a reasonable default for "lv" via the "LV" environment variable when spawning the pager. * mh/shorten-unambigous-ref (2014-01-09) 3 commits + shorten_unambiguous_ref(): tighten up pointer arithmetic + gen_scanf_fmt(): delete function and use snprintf() instead + shorten_unambiguous_ref(): introduce a new local variable * mm/mv-file-to-no-such-dir-with-slash (2014-01-10) 1 commit + mv: let 'git mv file no-such-dir/' error out on Windows, too Finishing touches to a topic that has already been merged to 'master'. * ow/stash-with-ifs (2014-01-07) 1 commit (merged to 'next' on 2014-01-10 at 4fc9bdb) + stash: handle specifying stashes with $IFS The implementation of 'git stash $cmd "stash@{...}"' did not quote the stash argument properly and left it split at IFS whitespace. * rr/completion-format-coverletter (2014-01-07) 1 commit (merged to 'next' on 2014-01-10 at d2dbc9d) + completion: complete format.coverLetter The bash/zsh completion code did not know about format.coverLetter among many format.* configuration variables. -------------------------------------------------- [New Topics] * ab/subtree-doc (2014-01-13) 1 commit - subtree: fix argument validation in add/pull/push Will merge to 'next'. * jk/complete-merge-base (2014-01-13) 2 commits - completion: handle --[no-]fork-point options to git-rebase - completion: complete merge-base options Will merge to 'next'. * po/everyday-doc (2014-01-13) 1 commit - Make 'git help everyday' work * rb/merge-prepare-commit-msg-hook (2014-01-10) 4 commits - merge: drop unused arg from abort_commit method signature - merge: make prepare_to_commit responsible for write_merge_state - t7505: ensure cleanup after hook blocks merge - t7505: add missing && Expose more merge states (e.g. $GIT_DIR/MERGE_MODE) to hooks that run during "git merge". The log stressed too much on one hook, prepare-commit-msg, but it would equally apply to other hooks like post-merge, I think. Waiting to give a chance to reroll. * bl/blame-full-history (2014-01-14) 1 commit - blame: new option --prefer-first to better handle merged cherry-picks * da/pull-ff-configuration (2014-01-15) 2 commits - pull: add --ff-only to the help text - pull: add pull.ff configuration Will merge to 'next'. * jc/maint-pull-docfix (2014-01-14) 2 commits - Documentation: "git pull" does not have the "-m" option - Merge branch 'jc/maint-pull-docfix-for-409b8d82' into jc/maint-pull-docfix (this branch uses jc/maint-pull-docfix-for-409b8d82.) Will merge to 'next'. * jc/maint-pull-docfix-for-409b8d82 (2014-01-14) 1 commit - Documentation: exclude irrelevant options from "git pull" (this branch is used by jc/maint-pull-docfix.) Will merge to 'next'. * jc/revision-range-unpeel (2014-01-15) 2 commits - revision: propagate flag bits from tags to pointees - revision: mark contents of an uninteresting tree uninteresting "git log --left-right A...B" lost the "leftness" of commits reachable from A when A is a tag as a side effect of a recent bugfix. This is a regression in 1.8.4.x series. Will merge to 'next'. * jk/allow-fetch-onelevel-refname (2014-01-15) 1 commit - fetch-pack: do not filter out one-level refs "git clone" would fail to clone from a repository that has a ref directly under "refs/", e.g. "refs/stash", because different validation paths do different things on such a refname. Loosen the client side's validation to allow such a ref. Will merge to 'next'. * jk/interpret-branch-name-fix (2014-01-15) 5 commits - interpret_branch_name: find all possible @-marks - interpret_branch_name: avoid @{upstream} past colon - interpret_branch_name: always respect "namelen" parameter - interpret_branch_name: rename "cp" variable to "at" - interpret_branch_name: factor out upstream handling Fix a handful of bugs around interpreting $branch@{upstream} notation and its lookalike, when $branch part has interesting characters, e.g. "@", and ":". Will merge to 'next'. * mh/attr-macro-doc (2014-01-14) 1 commit - gitattributes: document more clearly where macros are allowed Will merge to 'next'. * mh/retire-ref-fetch-rules (2014-01-14) 1 commit - refname_match(): always use the rules in ref_rev_parse_rules Code simplification. Will merge to 'next'. -------------------------------------------------- [Stalled] * jc/graph-post-root-gap (2013-12-30) 3 commits - WIP: document what we want at the end - graph: remove unused code a bit - graph: stuff the current commit into graph->columns[] This was primarily a RFH ($gmane/239580). * fc/transport-helper-fixes (2013-12-09) 6 commits - remote-bzr: support the new 'force' option - test-hg.sh: tests are now expected to pass - transport-helper: check for 'forced update' message - transport-helper: add 'force' to 'export' helpers - transport-helper: don't update refs in dry-run - transport-helper: mismerge fix Updates transport-helper, fast-import and fast-export to allow the ref mapping and ref deletion in a way similar to the natively supported transports. Reported to break t5541. Will hold. * fc/completion (2013-12-09) 1 commit - completion: fix completion of certain aliases SZEDER Gábor noticed that this breaks "git -c var=val alias" and also suggested a better description of the change. Will hold. * mo/subtree-split-updates (2013-12-10) 3 commits - subtree: add --edit option - subtree: allow --squash and --message with push - subtree: support split --rejoin --squash Comments? * hv/submodule-ignore-fix (2013-12-06) 4 commits - disable complete ignorance of submodules for index <-> HEAD diff - always show committed submodules in summary after commit - teach add -f option for ignored submodules - fix 'git add' to skip submodules configured as ignored Teach "git add" to be consistent with "git status" when changes to submodules are set to be ignored, to avoid surprises after checking with "git status" to see there isn't any change to be further added and then see that "git add ." adds changes to them. I think a reroll is coming, so this may need to be replaced, but I needed some practice with heavy conflict resolution. It conflicts with two changes to "git add" that have been scheduled for Git 2.0 quite badly, and I think I got the resolution right this time. * kb/fast-hashmap (2014-01-03) 19 commits - hashmap.h: make sure map entries are tightly packed (merged to 'next' on 2014-01-03 at dc85001) + name-hash: retire unused index_name_exists() + hashmap.h: Use 'unsigned int' for hash-codes everywhere (merged to 'next' on 2013-12-16 at bff99b1) + Drop unnecessary #includes from test-hashmap + Add test-hashmap to .gitignore (merged to 'next' on 2013-12-06 at f90be3d) + read-cache.c: fix memory leaks caused by removed cache entries + builtin/update-index.c: cleanup update_one + fix 'git update-index --verbose --again' output + remove old hash.[ch] implementation + name-hash.c: remove cache entries instead of marking them CE_UNHASHED + name-hash.c: use new hash map implementation for cache entries + name-hash.c: remove unreferenced directory entries + name-hash.c: use new hash map implementation for directories + diffcore-rename.c: use new hash map implementation + diffcore-rename.c: simplify finding exact renames + diffcore-rename.c: move code around to prepare for the next patch + buitin/describe.c: use new hash map implementation + add a hashtable implementation that supports O(1) removal + submodule: don't access the .gitmodules cache entry after removing it Improvements to our hash table to get it to meet the needs of the msysgit fscache project, with some nice performance improvements. The tip one does not seem to have reached concensus (yet). * jc/create-directories-microopt (2013-11-11) 1 commit - checkout: most of the time we have good leading directories Of unknown value until tested on non-Linux platforms (especially Windows). Will hold. * jt/commit-fixes-footer (2013-10-30) 1 commit - commit: Add -f, --fixes <commit> option to add Fixes: line There is an ongoing discussion around this topic; in general I am fairly negative on a new feature that is too narrow and prefer a more generic solution that can be tailored for specific needs, as many people stated in the thread. It appears that the discussion stalled. * np/pack-v4 (2013-09-18) 90 commits . packv4-parse.c: add tree offset caching . t1050: replace one instance of show-index with verify-pack . index-pack, pack-objects: allow creating .idx v2 with .pack v4 . unpack-objects: decode v4 trees . unpack-objects: allow to save processed bytes to a buffer - ... Nico and Duy advancing the eternal vaporware pack-v4. This is here primarily for wider distribution of the preview edition. Temporarily ejected from 'pu', to try out jk/pack-bitmap, which this topic conflicts with. * mf/graph-show-root (2013-10-25) 1 commit . graph.c: mark root commit differently In a repository with multiple-roots, "log --graph", especially with "--oneline", does not give the reader enough visual cue to see where one line of history ended and a separate history began. This is the version that marks the roots 'x' when they would have been marked as '*'; Keshav Kini suggested an alternative of giving an extra blank line after every root, which I tend to think is a better approach to the problem. * tg/perf-lib-test-perf-cleanup (2013-09-19) 2 commits - perf-lib: add test_perf_cleanup target - perf-lib: split starting the test from the execution Add test_perf_cleanup shell function to the perf suite, that allows the script writers to define a test with a clean-up action. Holding until needed. * yt/shortened-rename (2013-10-18) 2 commits - SQUASH??? style fixes and s/omit/shorten/ where appropriate - diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible Attempts to give more weight on the fact that a filepair represents a rename than showing substring of the actual path when diffstat lines are not wide enough. I am not sure if that is solving a right problem, though. * rv/send-email-cache-generated-mid (2013-08-21) 2 commits - git-send-email: Cache generated message-ids, use them when prompting - git-send-email: add optional 'choices' parameter to the ask sub * rj/read-default-config-in-show-ref-pack-refs (2013-06-17) 3 commits - ### DONTMERGE: needs better explanation on what config they need - pack-refs.c: Add missing call to git_config() - show-ref.c: Add missing call to git_config() The changes themselves are probably good, but it is unclear what basic setting needs to be read for which exact operation. Waiting for clarification. $gmane/228294 * jc/format-patch (2013-04-22) 2 commits - format-patch: --inline-single - format-patch: rename "no_inline" field A new option to send a single patch to the standard output to be appended at the bottom of a message. I personally have no need for this, but it was easy enough to cobble together. Tests, docs and stripping out more MIMEy stuff are left as exercises to interested parties. * jk/gitweb-utf8 (2013-04-08) 4 commits - gitweb: Fix broken blob action parameters on blob/commitdiff pages - gitweb: Don't append ';js=(0|1)' to external links - gitweb: Make feed title valid utf8 - gitweb: Fix utf8 encoding for blob_plain, blobdiff_plain, commitdiff_plain, and patch Various fixes to gitweb. Drew Northup volunteered to take a look into this. $gmane/226216 * jc/show-branch (2013-06-07) 5 commits - show-branch: use commit slab to represent bitflags of arbitrary width - show-branch.c: remove "all_mask" - show-branch.c: abstract out "flags" operation - show-branch.c: lift all_mask/all_revs to a global static - show-branch.c: update comment style Waiting for the final step to lift the hard-limit before sending it out. -------------------------------------------------- [Cooking] * wk/submodule-on-branch (2014-01-16) 6 commits - Documentation: Describe 'submodule update' modes in detail - t7406: Add explicit tests for head attachement after cloning updates - [DONOTMERGE] t7406: Just-cloned checkouts update to the gitlinked hash with 'reset' - submodule: Explicit local branch creation in module_clone - submodule: Document module_clone arguments in comments - submodule: Make 'checkout' update_module explicit (this branch uses fp/submodule-checkout-mode.) Makes sure 'submodule update' modes that do not detach HEADs can be used more pleasantly by checking out a concrete branch when cloning them to prime the well. This round seems to be almost ready; further discussions are of course very much welcomed. Will wait for another reroll to fix minor nits, at least. * jk/branch-at-publish (2014-01-13) 6 commits - t1507 (rev-parse-upstream): fix typo in test title - implement @{publish} shorthand - branch_get: provide per-branch pushremote pointers - branch_get: return early on error - interpret_branch_name: factor out upstream handling - sha1_name: refactor upstream_mark Give an easier access to the tracking branches from "other" side in a triangular workflow by introducing B@{publish} that works in a similar way to how B@{upstream} does. Will rebase to share the same change with the jk/interpret-branch-name-fix topic. * jk/warn-on-object-refname-ambiguity (2014-01-09) 6 commits - get_sha1: drop object/refname ambiguity flag - get_sha1: speed up ambiguous 40-hex test - FIXUP: teach DO_FOR_EACH_NO_RECURSE to prime_ref_dir() - refs: teach for_each_ref a flag to avoid recursion - cat-file: fix a minor memory leak in batch_objects - cat-file: refactor error handling of batch_objects Expecting a reroll. * ap/remote-hg-skip-null-bookmarks (2014-01-02) 1 commit - remote-hg: do not fail on invalid bookmarks Reported to break tests ($gmane/240005) Expecting a reroll. * ss/safe-create-leading-dir-with-slash (2014-01-06) 1 commit - safe_create_leading_directories(): on Windows, \ can separate path components Expecting to be rolled into mh/safe-create-leading-directories * fp/submodule-checkout-mode (2014-01-07) 1 commit (merged to 'next' on 2014-01-10 at 647ba9b) + git-submodule.sh: 'checkout' is a valid update mode (this branch is used by wk/submodule-on-branch.) "submodule.*.update=checkout", when propagated from .gitmodules to .git/config, turned into a "submodule.*.update=none", which did not make much sense. Will merge to 'master'. * jl/submodule-recursive-checkout (2013-12-26) 5 commits - Teach checkout to recursively checkout submodules - submodule: teach unpack_trees() to update submodules - submodule: teach unpack_trees() to repopulate submodules - submodule: teach unpack_trees() to remove submodule contents - submodule: prepare for recursive checkout of submodules Expecting a reroll. * mh/safe-create-leading-directories (2014-01-06) 17 commits - rename_tmp_log(): on SCLD_VANISHED, retry - rename_tmp_log(): limit the number of remote_empty_directories() attempts - rename_tmp_log(): handle a possible mkdir/rmdir race - rename_ref(): extract function rename_tmp_log() - remove_dir_recurse(): handle disappearing files and directories - remove_dir_recurse(): tighten condition for removing unreadable dir - lock_ref_sha1_basic(): if locking fails with ENOENT, retry - lock_ref_sha1_basic(): on SCLD_VANISHED, retry - safe_create_leading_directories(): add new error value SCLD_VANISHED - cmd_init_db(): when creating directories, handle errors conservatively - safe_create_leading_directories(): introduce enum for return values - safe_create_leading_directories(): always restore slash at end of loop - safe_create_leading_directories(): split on first of multiple slashes - safe_create_leading_directories(): rename local variable - safe_create_leading_directories(): add explicit "slash" pointer - safe_create_leading_directories(): reduce scope of local variable - safe_create_leading_directories(): fix format of "if" chaining Code clean-up and protection against concurrent write access to the ref namespace. Asked Michael and Sebastian to work together to roll the latter's "allow passing p\a\t\h to safe_create_leading_dir()" into this. Expecting a reroll. * jk/pack-bitmap (2013-12-30) 21 commits (merged to 'next' on 2014-01-10 at bdbe0a4) + pack-bitmap: implement optional name_hash cache + t/perf: add tests for pack bitmaps + t: add basic bitmap functionality tests + count-objects: recognize .bitmap in garbage-checking + repack: consider bitmaps when performing repacks + repack: handle optional files created by pack-objects + repack: turn exts array into array-of-struct + repack: stop using magic number for ARRAY_SIZE(exts) + pack-objects: implement bitmap writing + rev-list: add bitmap mode to speed up object lists + pack-objects: use bitmaps when packing objects + pack-objects: split add_object_entry + pack-bitmap: add support for bitmap indexes + documentation: add documentation for the bitmap format + ewah: compressed bitmap implementation + compat: add endianness helpers + sha1_file: export `git_open_noatime` + revision: allow setting custom limiter function + pack-objects: factor out name_hash + pack-objects: refactor the packing list + revindex: export new APIs Borrows the bitmap index into packfiles from JGit to speed up enumeration of objects involved in a commit range without having to fully traverse the history. Will cook in 'next'. * nv/commit-gpgsign-config (2013-12-17) 3 commits (merged to 'next' on 2014-01-03 at 9780cbb) + test the commit.gpgsign config option + commit-tree: add and document --no-gpg-sign + Add the commit.gpgsign option to sign all commits Introduce commit.gpgsign configuration variable to force every commit to be GPG signed. The variable cannot be overriden from the command line of some of the commands that create commits except for "git commit" and "git commit-tree", but I am not convinced that it is a good idea to sprinkle support for --no-gpg-sign everywhere. Will cook in 'next'. * nd/shallow-clone (2014-01-09) 31 commits (merged to 'next' on 2014-01-09 at 6608634) + t5537: fix incorrect expectation in test case 10 (merged to 'next' on 2014-01-06 at 3dc7fab) + shallow: remove unused code + send-pack.c: mark a file-local function static (merged to 'next' on 2014-01-03 at a776065) + git-clone.txt: remove shallow clone limitations + prune: clean .git/shallow after pruning objects + clone: use git protocol for cloning shallow repo locally + send-pack: support pushing from a shallow clone via http + receive-pack: support pushing to a shallow clone via http + smart-http: support shallow fetch/clone + remote-curl: pass ref SHA-1 to fetch-pack as well + send-pack: support pushing to a shallow clone + receive-pack: allow pushes that update .git/shallow + connected.c: add new variant that runs with --shallow-file + add GIT_SHALLOW_FILE to propagate --shallow-file to subprocesses + receive/send-pack: support pushing from a shallow clone + receive-pack: reorder some code in unpack() + fetch: add --update-shallow to accept refs that update .git/shallow + upload-pack: make sure deepening preserves shallow roots + fetch: support fetching from a shallow repository + clone: support remote shallow repository + fetch-pack.h: one statement per bitfield declaration + fetch-pack.c: move shallow update code out of fetch_pack() + shallow.c: steps 6 and 7 to select new commits for .git/shallow + shallow.c: the 8 steps to select new commits for .git/shallow + shallow.c: extend setup_*_shallow() to accept extra shallow commits + connect.c: teach get_remote_heads to parse "shallow" lines + make the sender advertise shallow commits to the receiver + clone: prevent --reference to a shallow repository + send-pack: forbid pushing from a shallow repository + remote.h: replace struct extra_have_objects with struct sha1_array + transport.h: remove send_pack prototype, already defined in send-pack.h Fetching from a shallow-cloned repository used to be forbidden, primarily because the codepaths involved were not carefully vetted and we did not bother supporting such usage. This attempts to allow object transfer out of a shallow-cloned repository in a controlled way (i.e. the receiver become a shallow repository with truncated history). Will merge to 'master'. * jn/git-gui-chmod+x (2013-11-25) 1 commit - git-gui: chmod +x po2msg, windows/git-gui.sh Parked here until I get the same change back from the upstream git-gui tree. * jn/gitk-chmod+x (2013-11-25) 1 commit - gitk: chmod +x po2msg Parked here until I get the same change back from the upstream gitk tree. * cc/starts-n-ends-with-endgame (2013-12-05) 1 commit (merged to 'next' on 2014-01-07 at 4cdf8d0) + strbuf: remove prefixcmp() and suffixcmp() Endgame for the cc/starts-n-ends-with topic; this needs to be evil-merged with other topics that introduce new uses of prefix/suffix-cmp functions. Will cook in 'next' until Git 2.0. * gj/push-more-verbose-advice (2013-11-13) 1 commit (merged to 'next' on 2013-12-06 at 574b18a) + push: switch default from "matching" to "simple" Originally merged to 'next' on 2013-11-21 Explain 'simple' and 'matching' in "git push" advice message; the topmost patch is a rebase of jc/push-2.0-default-to-simple on top of it. Will cook in 'next' until Git 2.0. * tr/merge-recursive-index-only (2013-10-28) 3 commits - merge-recursive: -Xindex-only to leave worktree unchanged - merge-recursive: internal flag to avoid touching the worktree - merge-recursive: remove dead conditional in update_stages() Will hold until using script appears. * jn/add-2.0-u-A-sans-pathspec (2013-04-26) 1 commit (merged to 'next' on 2013-12-06 at ead2ec8) + git add: -u/-A now affects the entire working tree Will cook in 'next' until Git 2.0. * jc/core-checkstat-2.0 (2013-05-06) 1 commit (merged to 'next' on 2013-12-06 at ae18007) + core.statinfo: remove as promised in Git 2.0 Will cook in 'next' until Git 2.0. * jc/push-2.0-default-to-simple (2013-06-18) 1 commit (merged to 'next' on 2013-12-06 at 6fad61c) + push: switch default from "matching" to "simple" Will cook in 'next' until Git 2.0. * jc/add-2.0-ignore-removal (2013-04-22) 1 commit (merged to 'next' on 2013-12-06 at fbaa75a) + git add <pathspec>... defaults to "-A" Updated endgame for "git add <pathspec>" that defaults to "--all" aka "--no-ignore-removal". Will cook in 'next' until Git 2.0. * jc/hold-diff-remove-q-synonym-for-no-deletion (2013-07-19) 1 commit (merged to 'next' on 2013-12-06 at 083d67c) + diff: remove "diff-files -q" in a version of Git in a distant future Will cook in 'next' until a distant future. ^ permalink raw reply [flat|nested] 20+ messages in thread
* [ANNOUNCE] Git v1.9-rc0 2014-01-16 21:03 What's cooking in git.git (Jan 2014, #03; Thu, 16) Junio C Hamano @ 2014-01-21 22:14 ` Junio C Hamano 2014-01-22 12:53 ` Javier Domingo Cansino 2014-01-27 17:59 ` Kacper Kornet 0 siblings, 2 replies; 20+ messages in thread From: Junio C Hamano @ 2014-01-21 22:14 UTC (permalink / raw) To: git; +Cc: Linux Kernel An early preview release Git v1.9-rc0 is now available for testing at the usual places. I tagged this late last week, but forgot to send out the announcement before I left for the weekend, and then I wasn't well yesterday, but anyway. There still may be a few minor topics not in this preview but should be in the final release, but otherwise, this should be pretty close to "it". It has been reported that turning git.rc into git.res does not like the new 2-dewey-decimal release numbering scheme; packagers of various distro might find similar issues in their build procedures, in which case they have about 3 weeks to update them until the final release. The release tarballs are found at: http://code.google.com/p/git-core/downloads/list and their SHA-1 checksums are: 495108620f8547ec8e979549857dae96bfabb0f7 git-1.9.rc0.tar.gz daf964f46acd9ba72ebcdfbd1ef0c668206a0d92 git-htmldocs-1.9.rc0.tar.gz a3b83356f738d1452bcee1d43ac5267a08986292 git-manpages-1.9.rc0.tar.gz The following public repositories all have a copy of the v1.9-rc0 tag and the v1.9-rc0 branch that the tag points at: url = https://kernel.googlesource.com/pub/scm/git/git url = git://repo.or.cz/alt-git.git url = https://code.google.com/p/git-core/ url = git://git.sourceforge.jp/gitroot/git-core/git.git url = git://git-core.git.sourceforge.net/gitroot/git-core/git-core url = https://github.com/gitster/git Git v1.9 Release Notes (draft) ====================== Backward compatibility notes ---------------------------- "git submodule foreach $cmd $args" used to treat "$cmd $args" the same way "ssh" did, concatenating them into a single string and letting the shell unquote. Careless users who forget to sufficiently quote $args gets their argument split at $IFS whitespaces by the shell, and got unexpected results due to this. Starting from this release, the command line is passed directly to the shell, if it has an argument. Read-only support for experimental loose-object format, in which users could optionally choose to write in their loose objects for a short while between v1.4.3 to v1.5.3 era, has been dropped. The meanings of "--tags" option to "git fetch" has changed; the command fetches tags _in addition to_ what are fetched by the same command line without the option. The way "git push $there $what" interprets $what part given on the command line, when it does not have a colon that explicitly tells us what ref at the $there repository is to be updated, has been enhanced. A handful of ancient commands that have long been deprecated are finally gone (repo-config, tar-tree, lost-found, and peek-remote). Backward compatibility notes (for Git 2.0) ------------------------------------------ When "git push [$there]" does not say what to push, we have used the traditional "matching" semantics so far (all your branches were sent to the remote as long as there already are branches of the same name over there). In Git 2.0, the default will change to the "simple" semantics, which pushes: - only the current branch to the branch with the same name, and only when the current branch is set to integrate with that remote branch, if you are pushing to the same remote as you fetch from; or - only the current branch to the branch with the same name, if you are pushing to a remote that is not where you usually fetch from. Use the user preference configuration variable "push.default" to change this. If you are an old-timer who is used to the "matching" semantics, you can set the variable to "matching" to keep the traditional behaviour. If you want to live in the future early, you can set it to "simple" today without waiting for Git 2.0. When "git add -u" (and "git add -A") is run inside a subdirectory and does not specify which paths to add on the command line, it will operate on the entire tree in Git 2.0 for consistency with "git commit -a" and other commands. There will be no mechanism to make plain "git add -u" behave like "git add -u .". Current users of "git add -u" (without a pathspec) should start training their fingers to explicitly say "git add -u ." before Git 2.0 comes. A warning is issued when these commands are run without a pathspec and when you have local changes outside the current directory, because the behaviour in Git 2.0 will be different from today's version in such a situation. In Git 2.0, "git add <path>" will behave as "git add -A <path>", so that "git add dir/" will notice paths you removed from the directory and record the removal. Versions before Git 2.0, including this release, will keep ignoring removals, but the users who rely on this behaviour are encouraged to start using "git add --ignore-removal <path>" now before 2.0 is released. The default prefix for "git svn" will change in Git 2.0. For a long time, "git svn" created its remote-tracking branches directly under refs/remotes, but it will place them under refs/remotes/origin/ unless it is told otherwise with its --prefix option. Updates since v1.8.5 -------------------- Foreign interfaces, subsystems and ports. * The HTTP transport, when talking GSS-Negotiate, uses "100 Continue" response to avoid having to rewind and resend a large payload, which may not be always doable. * Various bugfixes to remote-bzr and remote-hg (in contrib/). * The build procedure is aware of MirBSD now. UI, Workflows & Features * Fetching from a shallowly-cloned repository used to be forbidden, primarily because the codepaths involved were not carefully vetted and we did not bother supporting such usage. This release attempts to allow object transfer out of a shallowly-cloned repository in a more controlled way (i.e. the receiver become a shallow repository with a truncated history). * Just like we give a reasonable default for "less" via the LESS environment variable, we now specify a reasonable default for "lv" via the "LV" environment variable when spawning the pager. * Two-level configuration variable names in "branch.*" and "remote.*" hierarchies, whose variables are predominantly three-level, were not completed by hitting a <TAB> in bash and zsh completions. * Fetching 'frotz' branch with "git fetch", while 'frotz/nitfol' remote-tracking branch from an earlier fetch was still there, would error out, primarily because the command was not told that it is allowed to lose any information on our side. "git fetch --prune" now can be used to remove 'frotz/nitfol' to make room to fetch and store 'frotz' remote-tracking branch. * "diff.orderfile=<file>" configuration variable can be used to pretend as if the "-O<file>" option were given from the command line of "git diff", etc. * The negative pathspec syntax allows "git log -- . ':!dir'" to tell us "I am interested in everything but 'dir' directory". * "git difftool" shows how many different paths there are in total, and how many of them have been shown so far, to indicate progress. * "git push origin master" used to push our 'master' branch to update the 'master' branch at the 'origin' repository. This has been enhanced to use the same ref mapping "git push origin" would use to determine what ref at the 'origin' to be updated with our 'master'. For example, with this configuration [remote "origin"] push = refs/heads/*:refs/review/* that would cause "git push origin" to push out our local branches to corresponding refs under refs/review/ hierarchy at 'origin', "git push origin master" would update 'refs/review/master' over there. Alternatively, if push.default is set to 'upstream' and our 'master' is set to integrate with 'topic' from the 'origin' branch, running "git push origin" while on our 'master' would update their 'topic' branch, and running "git push origin master" while on any of our branches does the same. * "gitweb" learned to treat ref hierarchies other than refs/heads as if they are additional branch namespaces (e.g. refs/changes/ in Gerrit). * "git for-each-ref --format=..." learned a few formatting directives; e.g. "%(color:red)%(HEAD)%(color:reset) %(refname:short) %(subject)". * The command string given to "git submodule foreach" is passed directly to the shell, without being eval'ed. This is a backward incompatible change that may break existing users. * "git log" and friends learned the "--exclude=<glob>" option, to allow people to say "list history of all branches except those that match this pattern" with "git log --exclude='*/*' --branches". * "git rev-parse --parseopt" learned a new "--stuck-long" option to help scripts parse options with an optional parameter. * The "--tags" option to "git fetch" no longer tells the command to fetch _only_ the tags. It instead fetches tags _in addition to_ what are fetched by the same command line without the option. Performance, Internal Implementation, etc. * When parsing a 40-hex string into the object name, the string is checked to see if it can be interpreted as a ref so that a warning can be given for ambiguity. The code kicked in even when the core.warnambiguousrefs is set to false to squelch this warning, in which case the cycles spent to look at the ref namespace were an expensive no-op, as the result was discarded without being used. * The naming convention of the packfiles has been updated; it used to be based on the enumeration of names of the objects that are contained in the pack, but now it also depends on how the packed result is represented---packing the same set of objects using different settings (or delta order) would produce a pack with different name. * "git diff --no-index" mode used to unnecessarily attempt to read the index when there is one. * The deprecated parse-options macro OPT_BOOLEAN has been removed; use OPT_BOOL or OPT_COUNTUP in new code. * A few duplicate implementations of prefix/suffix string comparison functions have been unified to starts_with() and ends_with(). * The new PERLLIB_EXTRA makefile variable can be used to specify additional directories Perl modules (e.g. the ones necessary to run git-svn) are installed on the platform when building. * "git merge-base" learned the "--fork-point" mode, that implements the same logic used in "git pull --rebase" to find a suitable fork point out of the reflog entries for the remote-tracking branch the work has been based on. "git rebase" has the same logic that can be triggered with the "--fork-point" option. * A third-party "receive-pack" (the responder to "git push") can advertise the "no-thin" capability to tell "git push" not to use the thin-pack optimization. Our receive-pack has always been capable of accepting and fattening a thin-pack, and will continue not to ask "git push" to use a non-thin pack. Also contains various documentation updates and code clean-ups. Fixes since v1.8.5 ------------------ Unless otherwise noted, all the fixes since v1.8.5 in the maintenance track are contained in this release (see the maintenance releases' notes for details). * "submodule.*.update=checkout", when propagated from .gitmodules to .git/config, turned into a "submodule.*.update=none", which did not make much sense. (merge efa8fd7 fp/submodule-checkout-mode later to maint). * The implementation of 'git stash $cmd "stash@{...}"' did not quote the stash argument properly and left it split at IFS whitespace. (merge 2a07e43 ow/stash-with-ifs later to maint). * The "--[no-]informative-errors" options to "git daemon" were parsed a bit too loosely, allowing any other string after these option names. (merge 82246b7 nd/daemon-informative-errors-typofix later to maint). * There is no reason to have a hardcoded upper limit of the number of parents for an octopus merge, created via the graft mechanism, but there was. (merge e228c17 js/lift-parent-count-limit later to maint). * The basic test used to leave unnecessary trash directories in the t/ directory. (merge 738a8be jk/test-framework-updates later to maint). * "git merge-base --octopus" used to leave cleaning up suboptimal result to the caller, but now it does the clean-up itself. (merge 8f29299 bm/merge-base-octopus-dedup later to maint). * A "gc" process running as a different user should be able to stop a new "gc" process from starting, but it didn't. (merge ed7eda8 km/gc-eperm later to maint). * An earlier "clean-up" introduced an unnecessary memory leak. (merge e1c1a32 jk/credential-plug-leak later to maint). * "git add -A" (no other arguments) in a totally empty working tree used to emit an error. (merge 64ed07c nd/add-empty-fix later to maint). * "git log --decorate" did not handle a tag pointed by another tag nicely. (merge 5e1361c bc/log-decoration later to maint). * When we figure out how many file descriptors to allocate for keeping packfiles open, a system with non-working getrlimit() could cause us to die(), but because we make this call only to get a rough estimate of how many is available and we do not even attempt to use up all file descriptors available ourselves, it is nicer to fall back to a reasonable low value rather than dying. (merge 491a8de jh/rlimit-nofile-fallback later to maint). * read_sha1_file(), that is the workhorse to read the contents given an object name, honoured object replacements, but there was no corresponding mechanism to sha1_object_info() that was used to obtain the metainfo (e.g. type & size) about the object. This led callers to weird inconsistencies. (merge 663a856 cc/replace-object-info later to maint). * "git cat-file --batch=", an admittedly useless command, did not behave very well. (merge 6554dfa jk/cat-file-regression-fix later to maint). * "git rev-parse <revs> -- <paths>" did not implement the usual disambiguation rules the commands in the "git log" family used in the same way. (merge 62f162f jk/rev-parse-double-dashes later to maint). * "git mv A B/", when B does not exist as a directory, should error out, but it didn't. (merge c57f628 mm/mv-file-to-no-such-dir-with-slash later to maint). * A workaround to an old bug in glibc prior to glibc 2.17 has been retired; this would remove a side effect of the workaround that corrupts system error messages in non-C locales. * SSL-related options were not passed correctly to underlying socket layer in "git send-email". (merge 5508f3e tr/send-email-ssl later to maint). * "git commit -v" appends the patch to the log message before editing, and then removes the patch when the editor returned control. However, the patch was not stripped correctly when the first modified path was a submodule. (merge 1a72cfd jl/commit-v-strip-marker later to maint). * "git fetch --depth=0" was a no-op, and was silently ignored. Diagnose it as an error. (merge 5594bca nd/transport-positive-depth-only later to maint). * Remote repository URL expressed in scp-style host:path notation are parsed more carefully (e.g. "foo/bar:baz" is local, "[::1]:/~user" asks to connect to user's home directory on host at address ::1. (merge a2036d7 tb/clone-ssh-with-colon-for-port later to maint). * "git diff -- ':(icase)makefile'" was unnecessarily rejected at the command line parser. (merge 887c6c1 nd/magic-pathspec later to maint). * "git cat-file --batch-check=ok" did not check the existence of the named object. (merge 4ef8d1d sb/sha1-loose-object-info-check-existence later to maint). * "git am --abort" sometimes complained about not being able to write a tree with an 0{40} object in it. (merge 77b43ca jk/two-way-merge-corner-case-fix later to maint). * Two processes creating loose objects at the same time could have failed unnecessarily when the name of their new objects started with the same byte value, due to a race condition. (merge b2476a6 jh/loose-object-dirs-creation-race later to maint). ---------------------------------------------------------------- Changes since v1.8.5 are as follows: Anders Kaseorg (1): submodule foreach: skip eval for more than one argument Antoine Pelisse (2): Prevent buffer overflows when path is too long remote-hg: test 'shared_path' in a moved clone Benny Siegert (1): Add MirBSD support to the build system. Brodie Rao (1): sha1_name: don't resolve refs when core.warnambiguousrefs is false Carlos Martín Nieto (1): send-pack: don't send a thin pack to a server which doesn't support it Christian Couder (15): environment: normalize use of prefixcmp() by removing " != 0" builtin/remote: remove postfixcmp() and use suffixcmp() instead strbuf: introduce starts_with() and ends_with() replace {pre,suf}fixcmp() with {starts,ends}_with() rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECT replace_object: don't check read_replace_refs twice sha1_file.c: add lookup_replace_object_extended() to pass flags sha1_object_info_extended(): add an "unsigned flags" parameter t6050: show that git cat-file --batch fails with replace objects sha1_file: perform object replacement in sha1_object_info_extended() builtin/replace: teach listing using short, medium or full formats t6050: add tests for listing with --format builtin/replace: unset read_replace_refs Documentation/git-replace: describe --format option replace info: rename 'full' to 'long' and clarify in-code symbols Crestez Dan Leonard (1): git p4: Use git diff-tree instead of format-patch Felipe Contreras (9): test-lib.sh: convert $TEST_DIRECTORY to an absolute path test-bzr.sh, test-hg.sh: allow running from any dir remote-helpers: add extra safety checks remote-hg: fix 'shared path' path remote-hg: add tests for special filenames abspath: trivial style fix t: trivial whitespace cleanups fetch: add missing documentation remote: fix status with branch...rebase=preserve Francesco Pretto (1): git-submodule.sh: 'checkout' is a valid update mode Greg Jacobson (1): push: enhance unspecified push default warning Jason St. John (6): Documentation/git-log: update "--log-size" description Documentation/git-log.txt: mark-up fix and minor rephasing State correct usage of literal examples in man pages in the coding standards Documentation/rev-list-options.txt: fix mark-up Documentation/rev-list-options.txt: fix some grammatical issues and typos Documentation/gitcli.txt: fix double quotes Jeff King (30): log_tree_diff: die when we fail to parse a commit assume parse_commit checks commit->object.parsed assume parse_commit checks for NULL commit use parse_commit_or_die instead of segfaulting use parse_commit_or_die instead of custom message checkout: do not die when leaving broken detached HEAD sha1write: make buffer const-correct use @@PERL@@ in built scripts http: return curl's AUTHAVAIL via slot_results remote-curl: pass curl slot_results back through run_slot unpack-trees: fix "read-tree -u --reset A B" with conflicted index drop support for "experimental" loose objects t5000: simplify gzip prerequisite checks pack-objects: name pack files after trailer hash rev-parse: correctly diagnose revision errors before "--" rev-parse: be more careful with munging arguments cat-file: pass expand_data to print_object_or_die cat-file: handle --batch format with missing type/size pack-objects doc: treat output filename as opaque diff.c: fix some recent whitespace style violations builtin/prune.c: use strbuf to avoid having to worry about PATH_MAX do not pretend sha1write returns errors sha1_object_info_extended: provide delta base sha1s cat-file: provide %(deltabase) batch format Revert "prompt: clean up strbuf usage" use distinct username/password for http auth tests t0000: set TEST_OUTPUT_DIRECTORY for sub-tests t0000: simplify HARNESS_ACTIVE hack t0000: drop "known breakage" test t5531: further "matching" fixups Jens Lehmann (4): submodule update: remove unnecessary orig_flags variable commit -v: strip diffs and submodule shortlogs from the commit message mv: better document side effects when moving a submodule rm: better document side effects when removing a submodule Johan Herland (1): sha1_file.c:create_tmpfile(): Fix race when creating loose object dirs Johannes Schindelin (1): Remove the line length limit for graft files Johannes Sixt (4): document --exclude option git_connect: remove artificial limit of a remote command git_connect: factor out discovery of the protocol and its parts mv: let 'git mv file no-such-dir/' error out on Windows, too John Keeping (8): repo-config: remove deprecated alias for "git config" tar-tree: remove deprecated command lost-found: remove deprecated command peek-remote: remove deprecated alias of ls-remote pull: use merge-base --fork-point when appropriate rebase: use reflog to find common base with upstream rebase: fix fork-point with zero arguments pull: suppress error when no remoteref is found John Murphy (1): git-gui: corrected setup of git worktree under cygwin. John Szakmeister (1): contrib/git-credential-gnome-keyring.c: small stylistic cleanups Jonathan Nieder (16): git-remote-mediawiki: do not remove installed files in "clean" target git-remote-mediawiki: honor DESTDIR in "make install" git-remote-mediawiki build: make 'install' command configurable git-remote-mediawiki build: handle DESTDIR/INSTLIBDIR with whitespace Makefile: rebuild perl scripts when perl paths change Makefile: add PERLLIB_EXTRA variable that adds to default perl path mark Windows build scripts executable mark perl test scripts executable mark contributed hooks executable contrib: remove git-p4import test: make FILEMODE a lazy prereq test: replace shebangs with descriptions in shell libraries remove #!interpreter line from shell libraries stop installing git-tar-tree link pager: set LV=-c alongside LESS=FRSX diff test: reading a directory as a file need not error out Junio C Hamano (28): revision: introduce --exclude=<glob> to tame wildcards merge-base: use OPT_CMDMODE and clarify the command line parsing merge-base: teach "--fork-point" mode rev-list --exclude: tests rev-list --exclude: export add/clear-ref-exclusion and ref-excluded API rev-parse: introduce --exclude=<glob> to tame wildcards t1005: reindent t1005: add test for "read-tree --reset -u A B" sha1_loose_object_info(): do not return success on missing object bundle: use argv-array submodule: do not copy unknown update mode from .gitmodules Git 1.8.4.5 Git 1.8.5.1 builtin/push.c: use strbuf instead of manual allocation push: use remote.$name.push as a refmap push: also use "upstream" mapping when pushing a single ref Start 1.9 cycle Update draft release notes to 1.9 prune-packed: use strbuf to avoid having to worry about PATH_MAX Git 1.8.5.2 Update draft release notes to 1.9 get_max_fd_limit(): fall back to OPEN_MAX upon getrlimit/sysconf failure merge-base: separate "--independent" codepath into its own helper merge-base --octopus: reduce the result from get_octopus_merge_bases() Update draft release notes to 1.9 Git 1.8.5.3 Update draft release notes to 1.9 Git 1.9-rc0 Karsten Blees (1): gitignore.txt: clarify recursive nature of excluded directories Krzesimir Nowak (4): gitweb: Move check-ref-format code into separate function gitweb: Return 1 on validation success instead of passed input gitweb: Add a feature for adding more branch refs gitweb: Denote non-heads, non-remotes branches Kyle J. McKay (1): gc: notice gc processes run by other users Mads Dørup (1): git-gui: Improve font rendering on retina macbooks Masanari Iida (4): typofixes: fix misspelt comments Documentation/technical/http-protocol.txt: typofixes contrib: typofixes git-gui: correct spelling errors in comments Matthieu Moy (1): mv: let 'git mv file no-such-dir/' error out Max Kirillov (2): git-gui: Add gui.displayuntracked option git-gui: right half window is paned Michael Haggerty (27): t5510: use the correct tag name in test t5510: prepare test refs more straightforwardly t5510: check that "git fetch --prune --tags" does not prune branches api-remote.txt: correct section "struct refspec" get_ref_map(): rename local variables builtin/fetch.c: reorder function definitions get_expanded_map(): add docstring get_expanded_map(): avoid memory leak fetch: only opportunistically update references based on command line fetch --tags: fetch tags *in addition to* other stuff fetch --prune: prune only based on explicit refspecs query_refspecs(): move some constants out of the loop builtin/remote.c: reorder function definitions builtin/remote.c:update(): use struct argv_array fetch, remote: properly convey --no-prune options to subprocesses fetch-options.txt: simplify ifdef/ifndef/endif usage git-fetch.txt: improve description of tag auto-following ref_remove_duplicates(): avoid redundant bisection t5536: new test of refspec conflicts when fetching ref_remove_duplicates(): simplify loop logic ref_remote_duplicates(): extract a function handle_duplicate() handle_duplicate(): mark error message for translation fetch: improve the error messages emitted for conflicting refspecs cmd_repack(): remove redundant local variable "nr_packs" shorten_unambiguous_ref(): introduce a new local variable gen_scanf_fmt(): delete function and use snprintf() instead shorten_unambiguous_ref(): tighten up pointer arithmetic Nguyễn Thái Ngọc Duy (41): wt-status: take the alignment burden off translators diff: restrict pathspec limitations to diff b/f case only glossary-content.txt: fix documentation of "**" patterns gettext.c: detect the vsnprintf bug at runtime clone,fetch: catch non positive --depth option value glossary-content.txt: rephrase magic signature part Support pathspec magic :(exclude) and its short form :! pathspec.c: support adding prefix magic to a pathspec with mnemonic magic parse-options: remove OPT_BOOLEAN transport.h: remove send_pack prototype, already defined in send-pack.h remote.h: replace struct extra_have_objects with struct sha1_array send-pack: forbid pushing from a shallow repository clone: prevent --reference to a shallow repository make the sender advertise shallow commits to the receiver connect.c: teach get_remote_heads to parse "shallow" lines shallow.c: extend setup_*_shallow() to accept extra shallow commits shallow.c: the 8 steps to select new commits for .git/shallow shallow.c: steps 6 and 7 to select new commits for .git/shallow fetch-pack.c: move shallow update code out of fetch_pack() fetch-pack.h: one statement per bitfield declaration clone: support remote shallow repository fetch: support fetching from a shallow repository upload-pack: make sure deepening preserves shallow roots fetch: add --update-shallow to accept refs that update .git/shallow receive-pack: reorder some code in unpack() receive/send-pack: support pushing from a shallow clone add GIT_SHALLOW_FILE to propagate --shallow-file to subprocesses connected.c: add new variant that runs with --shallow-file receive-pack: allow pushes that update .git/shallow send-pack: support pushing to a shallow clone remote-curl: pass ref SHA-1 to fetch-pack as well smart-http: support shallow fetch/clone receive-pack: support pushing to a shallow clone via http send-pack: support pushing from a shallow clone via http clone: use git protocol for cloning shallow repo locally prune: clean .git/shallow after pruning objects git-clone.txt: remove shallow clone limitations daemon: be strict at parsing parameters --[no-]informative-errors add: don't complain when adding empty project root commit.c: make "tree" a const pointer in commit_tree*() t5537: fix incorrect expectation in test case 10 Nick Townsend (1): ref-iteration doc: add_submodule_odb() returns 0 for success Nicolas Vigier (2): Use the word 'stuck' instead of 'sticked' rev-parse --parseopt: add the --stuck-long mode Pat Thoyts (3): git-gui: added gui.maxrecentrepo to extend the number of remembered repos git-gui: show the maxrecentrepo config option in the preferences dialog git-gui: add menu item to launch a bash shell on Windows. Paul Mackerras (1): gitk: Tag display improvements Ralf Thielow (1): l10n: de.po: fix translation of 'prefix' Ramkumar Ramachandra (12): t6300 (for-each-ref): clearly demarcate setup t6300 (for-each-ref): don't hardcode SHA-1 hexes for-each-ref: introduce %(HEAD) asterisk marker for-each-ref: introduce %(upstream:track[short]) for-each-ref: introduce %(color:...) for color for-each-ref: avoid color leakage for-each-ref: remove unused variable zsh completion: find matching custom bash completion completion: introduce __gitcomp_nl_append () completion: fix branch.autosetup(merge|rebase) completion: fix remote.pushdefault completion: complete format.coverLetter Ramsay Allan Jones (2): send-pack.c: mark a file-local function static shallow: remove unused code René Scharfe (1): SubmittingPatches: document how to handle multiple patches Richard Hansen (6): test-bzr.sh, test-hg.sh: prepare for change to push.default=simple test-hg.sh: eliminate 'local' bashism test-hg.sh: avoid obsolete 'test' syntax test-hg.sh: fix duplicate content strings in author tests test-hg.sh: help user correlate verbose output with email test remote-bzr, remote-hg: fix email address regular expression Roberto Tyley (1): docs: add filter-branch notes on The BFG Roman Kagan (2): git-svn: workaround for a bug in svn serf backend git-svn: workaround for a bug in svn serf backend Samuel Bronson (3): t4056: add new tests for "git diff -O" diff: let "git diff -O" read orderfile from any file and fail properly diff: add diff.orderfile configuration variable Sebastian Schuberth (3): git.c: consistently use the term "builtin" instead of "internal command" builtin/help.c: call load_command_list() only when it is needed builtin/help.c: speed up is_git_command() by checking for builtin commands first Thomas Ackermann (2): user-manual: improve html and pdf formatting pack-heuristics.txt: mark up the file header properly Thomas Gummerer (4): diff: move no-index detection to builtin/diff.c diff: don't read index when --no-index is given diff: add test for --no-index executed outside repo diff: avoid some nesting Thomas Rast (13): commit-slab: document clear_$slabname() commit-slab: declare functions "static inline" Documentation: revamp git-cherry(1) gitk: Support -G option from the command line gitk: Refactor per-line part of getblobdiffline and its support gitk: Split out diff part in $commitinfo gitk: Support showing the gathered inline diffs gitk: Recognize -L option commit-slab: sizeof() the right type in xrealloc send-email: pass Debug to Net::SMTP::SSL::new send-email: --smtp-ssl-cert-path takes an argument send-email: set SSL options through IO::Socket::SSL::set_client_defaults config: arbitrary number of matches for --unset and --replace-all Tom Miller (2): fetch --prune: always print header url fetch --prune: Run prune before fetching Torsten Bögershausen (9): git-fetch-pack uses URLs like git-fetch t5601: remove clear_ssh, refactor setup_ssh_wrapper t5601: add tests for ssh git fetch-pack: add --diag-url t5500: add test cases for diag-url git fetch: support host:/~repo git_connect(): refactor the port handling for ssh connect.c: refactor url parsing git_connect(): use common return point Vasily Makarov (1): get_octopus_merge_bases(): cleanup redundant variable W. Trevor King (1): Documentation/gitmodules: Only 'update' and 'url' are required Zoltan Klinger (1): difftool: display the number of files in the diff queue in the prompt brian m. carlson (3): remote-curl: fix large pushes with GSSAPI Documentation: document pitfalls with 3-way merge log: properly handle decorations with chained tags jcb91 (1): remote-hg: avoid buggy strftime() Øystein Walle (1): stash: handle specifying stashes with $IFS ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-21 22:14 ` [ANNOUNCE] Git v1.9-rc0 Junio C Hamano @ 2014-01-22 12:53 ` Javier Domingo Cansino 2014-01-22 15:42 ` Junio C Hamano 2014-01-22 15:49 ` Stefan Näwe 2014-01-27 17:59 ` Kacper Kornet 1 sibling, 2 replies; 20+ messages in thread From: Javier Domingo Cansino @ 2014-01-22 12:53 UTC (permalink / raw) To: Junio C Hamano; +Cc: git@vger.kernel.org, Linux Kernel Will there be any change on how tarballs are distributed, taking into account that Google will be shutting down Google Code Downloads section[1][2]? Cheers Javier Domingo Cansino [1] Google Code download service change announcement: http://google-opensource.blogspot.se/2013/05/a-change-to-google-code-download-service.html [2] Google Code download section FAQ: https://code.google.com/p/support/wiki/DownloadsFAQ ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 12:53 ` Javier Domingo Cansino @ 2014-01-22 15:42 ` Junio C Hamano 2014-01-22 15:49 ` Stefan Näwe 1 sibling, 0 replies; 20+ messages in thread From: Junio C Hamano @ 2014-01-22 15:42 UTC (permalink / raw) To: Javier Domingo Cansino; +Cc: git@vger.kernel.org, Linux Kernel Javier Domingo Cansino <javierdo1@gmail.com> writes: > Will there be any change on how tarballs are distributed, taking into > account that Google will be shutting down Google Code Downloads > section[1][2]? Aside from the obvious "we won't be able to use something that is no longer offered"? They are not the only download site even now, so... ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 12:53 ` Javier Domingo Cansino 2014-01-22 15:42 ` Junio C Hamano @ 2014-01-22 15:49 ` Stefan Näwe 2014-01-22 16:11 ` Junio C Hamano 1 sibling, 1 reply; 20+ messages in thread From: Stefan Näwe @ 2014-01-22 15:49 UTC (permalink / raw) To: Javier Domingo Cansino, Junio C Hamano; +Cc: git@vger.kernel.org, Linux Kernel Am 22.01.2014 13:53, schrieb Javier Domingo Cansino: > Will there be any change on how tarballs are distributed, taking into > account that Google will be shutting down Google Code Downloads > section[1][2]? > Am I missing something or what's wrong with this: https://github.com/gitster/git/archive/v1.9-rc0.tar.gz or any https://github.com/gitster/git/archive/$TAG.tar.gz ?? (As long as Junio continues to push to github, of course) Stefan -- ---------------------------------------------------------------- /dev/random says: Folks who think they know it all bug those of us who do python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')" ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 15:49 ` Stefan Näwe @ 2014-01-22 16:11 ` Junio C Hamano 2014-01-22 17:26 ` Vicent Martí 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-22 16:11 UTC (permalink / raw) To: Stefan Näwe Cc: Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel Stefan Näwe <stefan.naewe@atlas-elektronik.com> writes: > Am 22.01.2014 13:53, schrieb Javier Domingo Cansino: >> Will there be any change on how tarballs are distributed, taking into >> account that Google will be shutting down Google Code Downloads >> section[1][2]? >> > > Am I missing something or what's wrong with this: > > https://github.com/gitster/git/archive/v1.9-rc0.tar.gz > > or any > > https://github.com/gitster/git/archive/$TAG.tar.gz > > ?? Do these consume CPU every time somebody asks for a tarball? That might be considered "wrong" depending on the view. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 16:11 ` Junio C Hamano @ 2014-01-22 17:26 ` Vicent Martí 2014-01-22 18:10 ` Junio C Hamano 0 siblings, 1 reply; 20+ messages in thread From: Vicent Martí @ 2014-01-22 17:26 UTC (permalink / raw) To: Junio C Hamano Cc: Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Wed, Jan 22, 2014 at 5:11 PM, Junio C Hamano <gitster@pobox.com> wrote: > Stefan Näwe <stefan.naewe@atlas-elektronik.com> writes: > >> Am 22.01.2014 13:53, schrieb Javier Domingo Cansino: >>> Will there be any change on how tarballs are distributed, taking into >>> account that Google will be shutting down Google Code Downloads >>> section[1][2]? >>> >> >> Am I missing something or what's wrong with this: >> >> https://github.com/gitster/git/archive/v1.9-rc0.tar.gz >> >> or any >> >> https://github.com/gitster/git/archive/$TAG.tar.gz >> >> ?? > > Do these consume CPU every time somebody asks for a tarball? That > might be considered "wrong" depending on the view. No, our infrastructure caches frequently requested tarballs so they don't have to be regenerated on the fly. If you would prefer to distribute a different version of the tarball for the release (e.g. one with a different filename or folder structure), you can upload it directly to the release page of the tag: https://github.com/gitster/git/releases/tag/v1.9-rc0 We'll automatically mirror your release to S3 and serve it from there. You can also go ahead and edit the release page with the changelog you've posted in this email thread to make it more user friendly. WE WILL SERVE YOUR RELEASES, JUNIO BECAUSE WE LOVE YOU -vmg ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 17:26 ` Vicent Martí @ 2014-01-22 18:10 ` Junio C Hamano 2014-01-22 20:30 ` Ken Moffat 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-22 18:10 UTC (permalink / raw) To: Vicent Martí Cc: Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel Vicent Martí <tanoku@gmail.com> writes: >> Do these consume CPU every time somebody asks for a tarball? That >> might be considered "wrong" depending on the view. > > No, our infrastructure caches frequently requested tarballs so they > don't have to be regenerated on the fly. Thanks. That is certainly good enough for consumers, and better than having to manually create and upload for me ;-) ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 18:10 ` Junio C Hamano @ 2014-01-22 20:30 ` Ken Moffat 2014-01-22 21:04 ` Junio C Hamano 2014-01-23 2:09 ` Jeff King 0 siblings, 2 replies; 20+ messages in thread From: Ken Moffat @ 2014-01-22 20:30 UTC (permalink / raw) To: Junio C Hamano Cc: Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Wed, Jan 22, 2014 at 10:10:18AM -0800, Junio C Hamano wrote: > Vicent Martí <tanoku@gmail.com> writes: > > >> Do these consume CPU every time somebody asks for a tarball? That > >> might be considered "wrong" depending on the view. > > > > No, our infrastructure caches frequently requested tarballs so they > > don't have to be regenerated on the fly. > > Thanks. That is certainly good enough for consumers, and better > than having to manually create and upload for me ;-) Two questions: Does regenerating (e.g. if the tarball has dropped out of the cache) change its sums (md5sum or similar) ? In (beyond) linuxfromscratch we use md5sums to verify that a tarball has not changed. Also, will there be links for manpages and htmldocs tarballs ? I note that all of these *are* still available at googlecode for the moment : https://code.google.com/p/git-core/downloads/list ĸen -- das eine Mal als Tragödie, dieses Mal als Farce ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 20:30 ` Ken Moffat @ 2014-01-22 21:04 ` Junio C Hamano 2014-01-22 23:11 ` Ken Moffat 2014-01-23 2:09 ` Jeff King 1 sibling, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-22 21:04 UTC (permalink / raw) To: Ken Moffat Cc: Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel Ken Moffat <zarniwhoop@ntlworld.com> writes: > I note that all of these *are* still available at googlecode for > the moment : https://code.google.com/p/git-core/downloads/list As I said, Cgc is not the ony download site. The end of http://git-blame.blogspot.com/p/git-public-repositories.html lists the two sites that currently have the material. I may replace Cgc with something else (and add it/them to the list), but in the meantime I do not think k.org will go out of business in anytime soon, so... ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 21:04 ` Junio C Hamano @ 2014-01-22 23:11 ` Ken Moffat 0 siblings, 0 replies; 20+ messages in thread From: Ken Moffat @ 2014-01-22 23:11 UTC (permalink / raw) To: Junio C Hamano Cc: Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Wed, Jan 22, 2014 at 01:04:02PM -0800, Junio C Hamano wrote: > Ken Moffat <zarniwhoop@ntlworld.com> writes: > > > I note that all of these *are* still available at googlecode for > > the moment : https://code.google.com/p/git-core/downloads/list > > As I said, Cgc is not the ony download site. The end of > > http://git-blame.blogspot.com/p/git-public-repositories.html > > lists the two sites that currently have the material. I may replace > Cgc with something else (and add it/them to the list), but in the > meantime I do not think k.org will go out of business in anytime > soon, so... > OK, thanks for the pointer to https://www.kernel.org/pub/software/scm/git/ for released tarballs. ĸen -- das eine Mal als Tragödie, dieses Mal als Farce ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-22 20:30 ` Ken Moffat 2014-01-22 21:04 ` Junio C Hamano @ 2014-01-23 2:09 ` Jeff King 2014-01-23 18:15 ` Junio C Hamano 1 sibling, 1 reply; 20+ messages in thread From: Jeff King @ 2014-01-23 2:09 UTC (permalink / raw) To: Ken Moffat Cc: Junio C Hamano, Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Wed, Jan 22, 2014 at 08:30:30PM +0000, Ken Moffat wrote: > Two questions: Does regenerating (e.g. if the tarball has dropped > out of the cache) change its sums (md5sum or similar) ? In (beyond) > linuxfromscratch we use md5sums to verify that a tarball has not > changed. The tarballs we auto-generate from tags are cached, but they can change if the cached version expires _and_ the archive-generation code changes. We use "git archive" to generate the tarballs themselves, and then gzip the with "gzip -n". So it should be consistent from run to run. However, very occasionally there are bugfixes in "git archive" which can affect the output. E.g., commit 22f0dcd (archive-tar: split long paths more carefully, 2013-01-05) changes the representation of certain long paths, and generating a tarball with and without it will result in different checksums (for some repos). So if you are planning on baking md5sums into a package-build system, it is much better to point at "official" releases which are rolled once by the project maintainer, rather than the automatic tag page. Junio, since you prepare such tarballs[1] anyway for kernel.org, it might be worth uploading them to the "Releases" page of git/git. I imagine there is a programmatic way to do so via GitHub's API, but I don't know offhand. I can look into it if you are interested. -Peff ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-23 2:09 ` Jeff King @ 2014-01-23 18:15 ` Junio C Hamano 2014-01-24 23:36 ` Jeff King 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-23 18:15 UTC (permalink / raw) To: Jeff King Cc: Ken Moffat, Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel Jeff King <peff@peff.net> writes: > Junio, since you prepare such tarballs[1] anyway for kernel.org, it > might be worth uploading them to the "Releases" page of git/git. I > imagine there is a programmatic way to do so via GitHub's API, but I > don't know offhand. I can look into it if you are interested. I already have a script that takes the three tarballs and uploads them to two places, so adding GitHub as the third destination should be a natural and welcome way to automate it. ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-23 18:15 ` Junio C Hamano @ 2014-01-24 23:36 ` Jeff King 2014-01-27 22:56 ` Junio C Hamano 0 siblings, 1 reply; 20+ messages in thread From: Jeff King @ 2014-01-24 23:36 UTC (permalink / raw) To: Junio C Hamano Cc: Ken Moffat, Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Thu, Jan 23, 2014 at 10:15:33AM -0800, Junio C Hamano wrote: > Jeff King <peff@peff.net> writes: > > > Junio, since you prepare such tarballs[1] anyway for kernel.org, it > > might be worth uploading them to the "Releases" page of git/git. I > > imagine there is a programmatic way to do so via GitHub's API, but I > > don't know offhand. I can look into it if you are interested. > > I already have a script that takes the three tarballs and uploads > them to two places, so adding GitHub as the third destination should > be a natural and welcome way to automate it. I came up with the script below, which you can use like: ./script v1.8.2.3 git-1.8.2.3.tar.gz It expects the tag to already be pushed up to GitHub. I'll leave sticking it on the "todo" branch and integrating it into RelUpload to you. This can also be used to backfill the old releases (though I looked on k.org and it seems to have only partial coverage). It sets the "prerelease" flag for -rc releases, but I did not otherwise fill in any fields, including the summary and description. GitHub seems to display reasonably if they are not set. -- >8 -- #!/bin/sh # # usage: $0 <tag> <tarball> repo=git/git # replace this with however you store your oauth token # if you don't have one, make one here: # https://github.com/settings/tokens/new token() { pass -n github.web.oauth } post() { curl -H "Authorization: token $(token)" "$@" } # usage: create <tag-name> create() { case "$1" in *-rc*) prerelease=true ;; *) prerelease=false ;; esac post -d ' { "tag_name": "'"$1"'", "prerelease": '"$prerelease"' }' "https://api.github.com/repos/$repo/releases" } # use: upload <release-id> <filename> upload() { url="https://uploads.github.com/repos/$repo/releases/$1/assets" && url="$url?name=$(basename $2)" && post -H "Content-Type: $(file -b --mime-type "$2")" \ --data-binary "@$2" \ "$url" } # This is a hack. If you don't mind a dependency on # perl's JSON (or another parser), we can do a lot better. extract_id() { perl -lne '/"id":\s*(\d+)/ or next; print $1; exit 0' } create "$1" >release.json && id=$(extract_id <release.json) && upload "$id" "$2" >/dev/null && rm -f release.json ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-24 23:36 ` Jeff King @ 2014-01-27 22:56 ` Junio C Hamano 2014-01-28 0:04 ` Jeff King 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2014-01-27 22:56 UTC (permalink / raw) To: Jeff King Cc: Ken Moffat, Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel Jeff King <peff@peff.net> writes: > On Thu, Jan 23, 2014 at 10:15:33AM -0800, Junio C Hamano wrote: > >> Jeff King <peff@peff.net> writes: >> >> > Junio, since you prepare such tarballs[1] anyway for kernel.org, it >> > might be worth uploading them to the "Releases" page of git/git. I >> > imagine there is a programmatic way to do so via GitHub's API, but I >> > don't know offhand. I can look into it if you are interested. >> >> I already have a script that takes the three tarballs and uploads >> them to two places, so adding GitHub as the third destination should >> be a natural and welcome way to automate it. > > I came up with the script below, which you can use like: > > ./script v1.8.2.3 git-1.8.2.3.tar.gz > > It expects the tag to already be pushed up to GitHub. I'll leave > sticking it on the "todo" branch and integrating it into RelUpload to > you. This can also be used to backfill the old releases (though I looked > on k.org and it seems to have only partial coverage). > > It sets the "prerelease" flag for -rc releases, but I did not otherwise > fill in any fields, including the summary and description. GitHub seems > to display reasonably if they are not set. Thanks. > -- >8 -- > #!/bin/sh > # > # usage: $0 <tag> <tarball> > > repo=git/git > > # replace this with however you store your oauth token > # if you don't have one, make one here: > # https://github.com/settings/tokens/new > token() { > pass -n github.web.oauth Hmph, what is this "pass" thing? > } > > post() { > curl -H "Authorization: token $(token)" "$@" > } > > # usage: create <tag-name> > create() { > case "$1" in > *-rc*) > prerelease=true > ;; > *) > prerelease=false > ;; > esac > > post -d ' > { > "tag_name": "'"$1"'", > "prerelease": '"$prerelease"' > }' "https://api.github.com/repos/$repo/releases" > } > > # use: upload <release-id> <filename> > upload() { > url="https://uploads.github.com/repos/$repo/releases/$1/assets" && > url="$url?name=$(basename $2)" && > post -H "Content-Type: $(file -b --mime-type "$2")" \ > --data-binary "@$2" \ > "$url" > } > > # This is a hack. If you don't mind a dependency on > # perl's JSON (or another parser), we can do a lot better. > extract_id() { > perl -lne '/"id":\s*(\d+)/ or next; print $1; exit 0' > } > > create "$1" >release.json && > id=$(extract_id <release.json) && > upload "$id" "$2" >/dev/null && > rm -f release.json ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-27 22:56 ` Junio C Hamano @ 2014-01-28 0:04 ` Jeff King 0 siblings, 0 replies; 20+ messages in thread From: Jeff King @ 2014-01-28 0:04 UTC (permalink / raw) To: Junio C Hamano Cc: Ken Moffat, Vicent Martí, Stefan Näwe, Javier Domingo Cansino, git@vger.kernel.org, Linux Kernel On Mon, Jan 27, 2014 at 02:56:28PM -0800, Junio C Hamano wrote: > > # replace this with however you store your oauth token > > # if you don't have one, make one here: > > # https://github.com/settings/tokens/new > > token() { > > pass -n github.web.oauth > > Hmph, what is this "pass" thing? It's a poor man's Keychain: https://github.com/peff/pass Judging from your use of netrc in Meta/RelUpload, you probably just want: token() { cat ~/.github-token } -Peff ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-21 22:14 ` [ANNOUNCE] Git v1.9-rc0 Junio C Hamano 2014-01-22 12:53 ` Javier Domingo Cansino @ 2014-01-27 17:59 ` Kacper Kornet 2014-01-27 18:58 ` Jonathan Nieder 1 sibling, 1 reply; 20+ messages in thread From: Kacper Kornet @ 2014-01-27 17:59 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Sitaram Chamarty On Tue, Jan 21, 2014 at 02:14:22PM -0800, Junio C Hamano wrote: > It has been reported that turning git.rc into git.res does not like > the new 2-dewey-decimal release numbering scheme; packagers of > various distro might find similar issues in their build procedures, > in which case they have about 3 weeks to update them until the final > release. The change in release numbering also breaks down gitolite v2 setups. One of the gitolite commands, gl-compile-conf, expects the output of git --version to match /git version (\d+)\.(\d+)\.(\d+)/. I have no idea how big problem it is, as I don't know how many people hasn't migrate to gitolite v3 yet. -- Kacper ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-27 17:59 ` Kacper Kornet @ 2014-01-27 18:58 ` Jonathan Nieder 2014-01-28 12:28 ` Kacper Kornet 0 siblings, 1 reply; 20+ messages in thread From: Jonathan Nieder @ 2014-01-27 18:58 UTC (permalink / raw) To: Kacper Kornet; +Cc: Junio C Hamano, git, Sitaram Chamarty Hi, Kacper Kornet wrote: > The change in release numbering also breaks down gitolite v2 setups. One > of the gitolite commands, gl-compile-conf, expects the output of git --version > to match /git version (\d+)\.(\d+)\.(\d+)/. > > I have no idea how big problem it is, as I don't know how many people > hasn't migrate to gitolite v3 yet. http://qa.debian.org/popcon.php?package=gitolite says there are some. I guess soon we'll see if there are complaints. http://gitolite.com/gitolite/migr.html says gitolite v2 is still maintained. Hopefully the patch to gitolite v2 to fix this would not be too invasive --- e.g., how about this patch (untested)? Thanks, Jonathan diff --git i/src/gl-compile-conf w/src/gl-compile-conf index f497ae5..8508313 100755 --- i/src/gl-compile-conf +++ w/src/gl-compile-conf @@ -394,8 +394,9 @@ die " the server. If it is not, please edit ~/.gitolite.rc on the server and set the \$GIT_PATH variable to the correct value\n " unless $git_version; -my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.(\d+)/); +my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.([^.-]*)/); die "$ABRT I can't understand $git_version\n" unless ($gv_maj >= 1); +$gv_patchrel = 0 unless ($gv_patchrel =~ m/^\d+$/); $git_version = $gv_maj*10000 + $gv_min*100 + $gv_patchrel; # now it's "normalised" die "\n\t\t***** AAARGH! *****\n" . ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-27 18:58 ` Jonathan Nieder @ 2014-01-28 12:28 ` Kacper Kornet 2014-01-30 22:20 ` Sitaram Chamarty 0 siblings, 1 reply; 20+ messages in thread From: Kacper Kornet @ 2014-01-28 12:28 UTC (permalink / raw) To: Jonathan Nieder; +Cc: Junio C Hamano, git, Sitaram Chamarty On Mon, Jan 27, 2014 at 10:58:29AM -0800, Jonathan Nieder wrote: > Hi, > Kacper Kornet wrote: > > The change in release numbering also breaks down gitolite v2 setups. One > > of the gitolite commands, gl-compile-conf, expects the output of git --version > > to match /git version (\d+)\.(\d+)\.(\d+)/. > > I have no idea how big problem it is, as I don't know how many people > > hasn't migrate to gitolite v3 yet. > http://qa.debian.org/popcon.php?package=gitolite says there are some. > I guess soon we'll see if there are complaints. > http://gitolite.com/gitolite/migr.html says gitolite v2 is still > maintained. Hopefully the patch to gitolite v2 to fix this would not > be too invasive --- e.g., how about this patch (untested)? > Thanks, > Jonathan > diff --git i/src/gl-compile-conf w/src/gl-compile-conf > index f497ae5..8508313 100755 > --- i/src/gl-compile-conf > +++ w/src/gl-compile-conf > @@ -394,8 +394,9 @@ die " > the server. If it is not, please edit ~/.gitolite.rc on the server and > set the \$GIT_PATH variable to the correct value\n > " unless $git_version; > -my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.(\d+)/); > +my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.([^.-]*)/); > die "$ABRT I can't understand $git_version\n" unless ($gv_maj >= 1); > +$gv_patchrel = 0 unless ($gv_patchrel =~ m/^\d+$/); > $git_version = $gv_maj*10000 + $gv_min*100 + $gv_patchrel; # now it's "normalised" > die "\n\t\t***** AAARGH! *****\n" . It works for 1.9.rc1 but I think it will fail with final 1.9. The following version should be ok: diff --git a/src/gl-compile-conf b/src/gl-compile-conf index f497ae5..c391468 100755 --- a/src/gl-compile-conf +++ b/src/gl-compile-conf @@ -394,7 +394,7 @@ die " the server. If it is not, please edit ~/.gitolite.rc on the server and set the \$GIT_PATH variable to the correct value\n " unless $git_version; -my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.(\d+)/); +my ($gv_maj, $gv_min, undef, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)(\.(\d+))?/); die "$ABRT I can't understand $git_version\n" unless ($gv_maj >= 1); $git_version = $gv_maj*10000 + $gv_min*100 + $gv_patchrel; # now it's "normalised" -- Kacper ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [ANNOUNCE] Git v1.9-rc0 2014-01-28 12:28 ` Kacper Kornet @ 2014-01-30 22:20 ` Sitaram Chamarty 0 siblings, 0 replies; 20+ messages in thread From: Sitaram Chamarty @ 2014-01-30 22:20 UTC (permalink / raw) To: Kacper Kornet, Jonathan Nieder; +Cc: Junio C Hamano, git On 01/28/2014 05:58 PM, Kacper Kornet wrote: > On Mon, Jan 27, 2014 at 10:58:29AM -0800, Jonathan Nieder wrote: >> Hi, > >> Kacper Kornet wrote: > >>> The change in release numbering also breaks down gitolite v2 setups. One >>> of the gitolite commands, gl-compile-conf, expects the output of git --version >>> to match /git version (\d+)\.(\d+)\.(\d+)/. > >>> I have no idea how big problem it is, as I don't know how many people >>> hasn't migrate to gitolite v3 yet. > >> http://qa.debian.org/popcon.php?package=gitolite says there are some. >> I guess soon we'll see if there are complaints. > >> http://gitolite.com/gitolite/migr.html says gitolite v2 is still >> maintained. Hopefully the patch to gitolite v2 to fix this would not >> be too invasive --- e.g., how about this patch (untested)? > >> Thanks, >> Jonathan > >> diff --git i/src/gl-compile-conf w/src/gl-compile-conf >> index f497ae5..8508313 100755 >> --- i/src/gl-compile-conf >> +++ w/src/gl-compile-conf >> @@ -394,8 +394,9 @@ die " >> the server. If it is not, please edit ~/.gitolite.rc on the server and >> set the \$GIT_PATH variable to the correct value\n >> " unless $git_version; >> -my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.(\d+)/); >> +my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.([^.-]*)/); >> die "$ABRT I can't understand $git_version\n" unless ($gv_maj >= 1); >> +$gv_patchrel = 0 unless ($gv_patchrel =~ m/^\d+$/); >> $git_version = $gv_maj*10000 + $gv_min*100 + $gv_patchrel; # now it's "normalised" > >> die "\n\t\t***** AAARGH! *****\n" . > > It works for 1.9.rc1 but I think it will fail with final 1.9. The > following version should be ok: > > diff --git a/src/gl-compile-conf b/src/gl-compile-conf > index f497ae5..c391468 100755 > --- a/src/gl-compile-conf > +++ b/src/gl-compile-conf > @@ -394,7 +394,7 @@ die " > the server. If it is not, please edit ~/.gitolite.rc on the server and > set the \$GIT_PATH variable to the correct value\n > " unless $git_version; > -my ($gv_maj, $gv_min, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)\.(\d+)/); > +my ($gv_maj, $gv_min, undef, $gv_patchrel) = ($git_version =~ m/git version (\d+)\.(\d+)(\.(\d+))?/); > die "$ABRT I can't understand $git_version\n" unless ($gv_maj >= 1); > $git_version = $gv_maj*10000 + $gv_min*100 + $gv_patchrel; # now it's "normalised" Gitolite v3 will be 2 years old in a month or so. I would prefer to use this as an opportunity to encourage people to upgrade; v2 really has nothing going for it now. People who cannot upgrade gitolite should simply cut that whole block of code and throw it out. Distro's should probably do that if they are still keeping gitolite v2 alive, because it is clearly not needed if the same distro is up to 1.9 of git! My policy has been to continue support for critical bugs. A bug that can be fixed by simply deleting the offending code block, with no harm done, is -- to my mind -- not critical enough :-) side note, Kacper: I'd use non-capturing parens than an undef in the destination list. ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2014-01-30 22:20 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-01-16 21:03 What's cooking in git.git (Jan 2014, #03; Thu, 16) Junio C Hamano 2014-01-21 22:14 ` [ANNOUNCE] Git v1.9-rc0 Junio C Hamano 2014-01-22 12:53 ` Javier Domingo Cansino 2014-01-22 15:42 ` Junio C Hamano 2014-01-22 15:49 ` Stefan Näwe 2014-01-22 16:11 ` Junio C Hamano 2014-01-22 17:26 ` Vicent Martí 2014-01-22 18:10 ` Junio C Hamano 2014-01-22 20:30 ` Ken Moffat 2014-01-22 21:04 ` Junio C Hamano 2014-01-22 23:11 ` Ken Moffat 2014-01-23 2:09 ` Jeff King 2014-01-23 18:15 ` Junio C Hamano 2014-01-24 23:36 ` Jeff King 2014-01-27 22:56 ` Junio C Hamano 2014-01-28 0:04 ` Jeff King 2014-01-27 17:59 ` Kacper Kornet 2014-01-27 18:58 ` Jonathan Nieder 2014-01-28 12:28 ` Kacper Kornet 2014-01-30 22:20 ` Sitaram Chamarty
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).