From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Stefan Beller <stefanbeller@googlemail.com>,
Siddharth Agarwal <sid0@fb.com>
Subject: Re: [PATCH 3/3] repack: propagate pack-objects options as strings
Date: Wed, 22 Jan 2014 20:38:47 -0500 [thread overview]
Message-ID: <20140123013847.GD17254@sigill.intra.peff.net> (raw)
In-Reply-To: <20140123013008.GC19472@sigill.intra.peff.net>
On Wed, Jan 22, 2014 at 08:30:13PM -0500, Jeff King wrote:
> - OPT_INTEGER(0, "window", &window,
> + OPT_STRING(0, "window", &window, N_("n"),
> N_("size of the window used for delta compression")),
By the way, the old code with OPT_INTEGER would always say "n" here, so
there is no change to "git repack -h" output here...
> - OPT_INTEGER(0, "max-pack-size", &max_pack_size,
> + OPT_STRING(0, "max-pack-size", &max_pack_size, N_("bytes"),
> N_("maximum size of each packfile")),
...but this one will now say:
--max-pack-size <bytes>
maximum size of each packfile
I think that is more descriptive, but pack-objects does just say "n". I
am OK with it either way.
-Peff
next prev parent reply other threads:[~2014-01-23 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 22:48 git repack --max-pack-size broken in git-next Siddharth Agarwal
2014-01-21 23:01 ` Junio C Hamano
2014-01-21 23:26 ` Junio C Hamano
2014-01-22 19:58 ` [PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4 Junio C Hamano
2014-01-22 19:58 ` [PATCH v2 1/2] parse-options: refactor human-friendly-integer parser out of pack-objects Junio C Hamano
2014-01-22 19:58 ` [PATCH v2 2/2] repack: accept larger window-memory and max-pack-size Junio C Hamano
2014-01-23 1:06 ` Jeff King
2014-01-23 1:26 ` Jeff King
2014-01-23 1:27 ` [PATCH 1/3] repack: fix typo in max-pack-size option Jeff King
2014-01-23 1:28 ` [PATCH 2/3] repack: make parsed string options const-correct Jeff King
2014-01-23 1:30 ` [PATCH 3/3] repack: propagate pack-objects options as strings Jeff King
2014-01-23 1:38 ` Jeff King [this message]
2014-01-23 18:37 ` [PATCH v2 2/2] repack: accept larger window-memory and max-pack-size Junio C Hamano
2014-01-22 22:33 ` [PATCH v2 0/2] Fix "repack --window-memory=4g" regression in 1.8.4 Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123013847.GD17254@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sid0@fb.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).