From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2014, #05; Mon, 27)
Date: Mon, 27 Jan 2014 19:40:42 -0500 [thread overview]
Message-ID: <20140128004042.GC17227@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq7g9lnkjz.fsf@gitster.dls.corp.google.com>
On Mon, Jan 27, 2014 at 02:09:52PM -0800, Junio C Hamano wrote:
> [Stalled]
>
> * jk/color-for-more-pagers (2014-01-17) 4 commits
> - pager: disable colors for some known-bad configurations
> - DONOTMERGE: needs matching change to git-sh-setup
> - setup_pager: set MORE=R
> - setup_pager: refactor LESS/LV environment setting
>
> 'more' implementation of BSD wants to be told with MORE=R
> environment before it shows colored output, while 'more' on some
> other platforms will die when seeing MORE=R environment.
>
> It appears that we are coming to the consensus that trying to be
> too intimately knowledgeable about quirks of various pager
> implementations on different platforms is a losing proposition, so
> perhaps I should replace this with the alternative and simpler
> approach I posted, unless there are strong objections.
It saddens me that we can't better help people who have a custom
LESS/MORE/LV set out of the box, but I think I agree that the intimacy
with the pagers was just getting too ugly. So I agree we want to drop
what you have there.
I was planning to try to clean up the "like this..." patch to the
Makefile I posted earlier, but haven't gotten around to it. It seemed
like you were positive on that approach. Let me see if I can do that.
-Peff
prev parent reply other threads:[~2014-01-28 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 22:09 What's cooking in git.git (Jan 2014, #05; Mon, 27) Junio C Hamano
2014-01-28 0:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128004042.GC17227@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).