From: Jeff King <peff@peff.net>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Kent R. Spillner" <kspillner@acm.org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org, "Johannes Sixt" <j.sixt@viscovery.net>,
"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH 0/3] Add a function skip_prefix_if_present()
Date: Wed, 5 Feb 2014 12:26:51 -0500 [thread overview]
Message-ID: <20140205172651.GC7268@sigill.intra.peff.net> (raw)
In-Reply-To: <52F1E04D.3090208@alum.mit.edu>
On Wed, Feb 05, 2014 at 07:55:09AM +0100, Michael Haggerty wrote:
> * René Scharfe submitted a patch to use a function parse_prefix()
> (originally suggested by Peff) instead of Duy's suggested approach:
>
> http://article.gmane.org/gmane.comp.version-control.git/239569
>
> His patch appears to have been overlooked.
>
> * Duy seemed to offer to rewrite his patch series, but I don't think
> that it has happened yet.
>
> And then the conversation was drowned by Christmas eggnog.
>
> I don't have a strong feeling about (Duy's proposal plus my patches) vs.
> (René's parse_prefix() approach). But I definitely *do* like the idea
> of getting rid of all those awkward magic numbers everywhere.
FWIW, after coming down off my eggnog bender, I think I still prefer
René's (my?) approach.
-Peff
next prev parent reply other threads:[~2014-02-05 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 6:25 [PATCH 0/3] Add a function skip_prefix_if_present() Michael Haggerty
2014-02-05 6:25 ` [PATCH 1/3] Add and use " Michael Haggerty
2014-02-05 6:25 ` [PATCH 2/3] diff_scoreopt_parse(): use skip_prefix_if_present() Michael Haggerty
2014-02-05 6:25 ` [PATCH 3/3] rev_is_head(): use skip_prefix() Michael Haggerty
2014-02-05 6:55 ` [PATCH 0/3] Add a function skip_prefix_if_present() Michael Haggerty
2014-02-05 17:26 ` Jeff King [this message]
2014-02-06 12:19 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205172651.GC7268@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=kspillner@acm.org \
--cc=l.s.r@web.de \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).