From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Adrian Johnson <ajohnson@redneon.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] userdiff: update Ada patterns
Date: Wed, 5 Feb 2014 12:28:44 -0500 [thread overview]
Message-ID: <20140205172844.GD7268@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqk3d95vic.fsf@gitster.dls.corp.google.com>
On Wed, Feb 05, 2014 at 09:17:47AM -0800, Junio C Hamano wrote:
> Adrian Johnson <ajohnson@redneon.com> writes:
>
> >>> - "|[0-9][-+0-9#_.eE]"
> >>> + "|[-+]?[0-9][0-9#_.aAbBcCdDeEfF]*([eE][+-]?[0-9_]+)?"
> >>
> >> This would match a lot wider than what I read you said you wanted to
> >> match in your previous message. Does "-04##4_3_2Ee-9" count as a
> >> number, for example, or can we just ignore such syntactically
> >> incorrect sequence?
> >
> > Maybe I am misunderstanding the purpose of the word diff regexes. I
> > thought the purpose of the word regex is to split lines into words, not
> > determine what is syntactically correct.
>
> I agree that the purpose is former---So you could have just said
> "the latter" ;-).
>
> Any other nitpick, anybody? Otherwise I'll queue this version.
No nitpick here, I had the same thought as Adrian while reading the
thread (and if somebody comes up with a real case where the output looks
bad, we can iterate on it).
-Peff
next prev parent reply other threads:[~2014-02-05 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 10:51 [PATCH] userdiff: update Ada patterns Adrian Johnson
2014-02-02 23:35 ` Jeff King
2014-02-03 11:30 ` Adrian Johnson
2014-02-03 11:33 ` [PATCH v2] " Adrian Johnson
2014-02-03 20:00 ` Junio C Hamano
2014-02-05 10:44 ` Adrian Johnson
2014-02-05 17:17 ` Junio C Hamano
2014-02-05 17:28 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-03 18:33 George Spelvin
2014-02-03 20:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205172844.GD7268@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ajohnson@redneon.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).