From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 13/13] move LESS/LV pager environment to Makefile Date: Wed, 5 Feb 2014 14:52:06 -0500 Message-ID: <20140205195206.GA16753@sigill.intra.peff.net> References: <20140205174823.GA15070@sigill.intra.peff.net> <20140205180857.GM15218@sigill.intra.peff.net> <20140205192350.GA16009@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Wed Feb 05 20:52:14 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WB8W6-0002ws-DY for gcvg-git-2@plane.gmane.org; Wed, 05 Feb 2014 20:52:14 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbaBETwL (ORCPT ); Wed, 5 Feb 2014 14:52:11 -0500 Received: from cloud.peff.net ([50.56.180.127]:45246 "HELO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751107AbaBETwI (ORCPT ); Wed, 5 Feb 2014 14:52:08 -0500 Received: (qmail 14547 invoked by uid 102); 5 Feb 2014 19:52:08 -0000 Received: from c-71-63-4-13.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (71.63.4.13) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Wed, 05 Feb 2014 13:52:08 -0600 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 05 Feb 2014 14:52:06 -0500 Content-Disposition: inline In-Reply-To: <20140205192350.GA16009@sigill.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Wed, Feb 05, 2014 at 02:23:50PM -0500, Jeff King wrote: > On Wed, Feb 05, 2014 at 01:08:57PM -0500, Jeff King wrote: > > > +quote() { > > + echo "$1" | sed 's/\\/\\\\/g; s/"/\\"/' > > +} > > This of course has the same "/g" bug as the earlier patch in the series. > > I was tempted to pull the function out into script/lib-c.sh, so that > both can source it, but perhaps that is overkill. Also, this (and the other spot) should probably be using "printf" instead of echo for portability (i.e., the config variables might have backslashes in them). -Peff