From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Stefan Beller" <stefanbeller@googlemail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
git@vger.kernel.org
Subject: Re: [PATCH] repack.c: rename and unlink pack file if it exists
Date: Wed, 5 Feb 2014 16:09:54 -0500 [thread overview]
Message-ID: <20140205210954.GA24142@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq7g992ror.fsf@gitster.dls.corp.google.com>
On Wed, Feb 05, 2014 at 01:08:36PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > ... So the fact that this
> > bug exists doesn't really produce any user-visible behavior, and
> > hopefully post-release we would drop the code entirely, and the test
> > would have no reason to exist.
>
> Heh, thanks, and I agree with the reasoning for the longer-term
> direction. Perhaps I can/should hold it off that minimal fix-up
> patch from -rc3, then? I am on the fence but I already started my
> today's integration cycle _with_ the fix merged to 'master', so...
I would say leave the fix for -rc3, but not worry about the test.
-Peff
next prev parent reply other threads:[~2014-02-05 21:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 23:40 [PATCH] repack.c: rename and unlink pack file if it exists Junio C Hamano
2014-02-04 23:43 ` Junio C Hamano
2014-02-05 1:16 ` Jeff King
2014-02-05 17:54 ` Torsten Bögershausen
2014-02-05 20:06 ` Junio C Hamano
2014-02-05 20:12 ` Jeff King
2014-02-05 20:31 ` Junio C Hamano
2014-02-05 20:37 ` Jeff King
2014-02-05 20:54 ` Jeff King
2014-02-05 20:57 ` Junio C Hamano
2014-02-05 21:01 ` Jeff King
2014-02-05 21:08 ` Junio C Hamano
2014-02-05 21:09 ` Jeff King [this message]
2014-02-05 21:01 ` Torsten Bögershausen
2014-02-05 20:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140205210954.GA24142@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stefanbeller@googlemail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).