From: Jeff King <peff@peff.net>
To: Thomas Adam <thomas@xteddy.org>
Cc: Yoshihiro Sugi <sugi1982@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: [PATCH] contrib/diff-highlight: multibyte characters diff
Date: Wed, 12 Feb 2014 18:27:40 -0500 [thread overview]
Message-ID: <20140212232740.GA11098@sigill.intra.peff.net> (raw)
In-Reply-To: <CA+39Oz5TSPNzYVvFytJwwUhRYjbEp5f_BdBWKT2tcYzpbF1WyQ@mail.gmail.com>
On Wed, Feb 12, 2014 at 11:10:49PM +0000, Thomas Adam wrote:
> On 12 February 2014 20:59, Jeff King <peff@peff.net> wrote:
> > +sub decode {
> > + my $orig = shift;
> > + my $decoded = eval { decode_utf8($orig, Encode::FB_CROAK) };
> > + return defined $decoded ?
>
> I'd still advocate checking $@ here, rather than the defined $decoded check.
I don't mind changing it, but for my edification, what is the advantage?
-Peff
next prev parent reply other threads:[~2014-02-12 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 9:09 [PATCH] contrib/diff-highlight: multibyte characters diff Yoshihiro Sugi
2014-02-11 19:30 ` Junio C Hamano
2014-02-12 20:59 ` Jeff King
2014-02-12 23:10 ` Thomas Adam
2014-02-12 23:27 ` Jeff King [this message]
2014-02-13 1:17 ` brian m. carlson
2014-02-13 1:37 ` Jeff King
2014-02-13 19:14 ` Yoshihiro Sugi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212232740.GA11098@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sugi1982@gmail.com \
--cc=thomas@xteddy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).