From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry
Date: Sat, 22 Feb 2014 03:12:31 -0500 [thread overview]
Message-ID: <20140222081231.GC1576@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqmwhk49sy.fsf@gitster.dls.corp.google.com>
On Fri, Feb 21, 2014 at 10:09:33AM -0800, Junio C Hamano wrote:
> >> This delta_stack array can grow to any length depending on the actual
> >> delta chain, but we forget to free it. Normally it does not matter
> >> because we use small_delta_stack[] from stack and small_delta_stack
> >> can hold 64-delta chains, more than standard --depth=50 in pack-objects.
> [...]
>
> This comes from abe601bb, right? The change looks correct to me, too.
Yes, it does.
-Peff
next prev parent reply other threads:[~2014-02-22 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 23:47 [PATCH] sha1_file: fix delta_stack memory leak in unpack_entry Nguyễn Thái Ngọc Duy
2014-02-21 5:41 ` Jeff King
2014-02-21 18:09 ` Junio C Hamano
2014-02-22 8:12 ` Jeff King [this message]
2014-02-22 15:44 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222081231.GC1576@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).