From: Jeff King <peff@peff.net>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] make commit --verbose work with --no-status
Date: Sat, 22 Feb 2014 03:31:10 -0500 [thread overview]
Message-ID: <20140222083110.GE1576@sigill.intra.peff.net> (raw)
In-Reply-To: <1393009762-31133-4-git-send-email-rctay89@gmail.com>
On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote:
> @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const char *argv[],
> if (all && argc > 0)
> die(_("Paths with -a does not make sense."));
>
> - if (status_format != STATUS_FORMAT_DEFAULT)
> + if (verbose && !include_status) {
> + include_status = 1;
> + status_format = STATUS_FORMAT_NONE;
> + }
> +
> + if (status_format != STATUS_FORMAT_DEFAULT && !verbose)
> dry_run = 1;
What happens here when there is an alternate status format _and_
--verbose is used? If I say "git commit --porcelain" it should imply
--dry-run. But "git commit --porcelain --verbose" no longer does so
after your patch.
-Peff
next prev parent reply other threads:[~2014-02-22 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 19:09 [PATCH 0/3] make commit --verbose work with --no-status Tay Ray Chuan
2014-02-21 19:09 ` [PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT Tay Ray Chuan
2014-02-21 19:09 ` [PATCH 2/3] extract setting of wt_status.commitable flag out of wt_status_print_updated() Tay Ray Chuan
2014-02-21 19:09 ` [PATCH 3/3] make commit --verbose work with --no-status Tay Ray Chuan
2014-02-22 8:31 ` Jeff King [this message]
2014-02-24 4:24 ` Tay Ray Chuan
2014-02-24 8:33 ` Jeff King
2014-02-22 8:24 ` [PATCH 1/3] rename STATUS_FORMAT_NONE to STATUS_FORMAT_DEFAULT Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222083110.GE1576@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).