From: Jeff King <peff@peff.net>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 4/4] config: teach "git config --file -" to read from the standard input
Date: Sat, 22 Feb 2014 03:37:44 -0500 [thread overview]
Message-ID: <20140222083744.GG1576@sigill.intra.peff.net> (raw)
In-Reply-To: <1392764335-13274-4-git-send-email-kirill@shutemov.name>
On Wed, Feb 19, 2014 at 12:58:55AM +0200, Kirill A. Shutemov wrote:
> The patch extends git config --file interface to allow read config from
> stdin.
>
> Editing stdin or setting value in stdin is an error.
>
> Include by absolute path is allowed in stdin config, but not by relative
> path.
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> ---
This version of the series looks good to me.
-Peff
prev parent reply other threads:[~2014-02-22 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:58 [PATCH 1/4] config: disallow relative include paths from blobs Kirill A. Shutemov
2014-02-18 22:58 ` [PATCH 2/4] builtin/config.c: rename check_blob_write() -> check_write() Kirill A. Shutemov
2014-02-18 22:58 ` [PATCH 3/4] config: change git_config_with_options() interface Kirill A. Shutemov
2014-02-18 22:58 ` [PATCH 4/4] config: teach "git config --file -" to read from the standard input Kirill A. Shutemov
2014-02-22 8:37 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140222083744.GG1576@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kirill@shutemov.name \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).