From: Jeff King <peff@peff.net>
To: Richard Lowe <richlowe@richlowe.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diffcore.h: be explicit about the signedness of is_binary
Date: Sun, 23 Feb 2014 21:09:40 -0500 [thread overview]
Message-ID: <20140224020940.GB7959@sigill.intra.peff.net> (raw)
In-Reply-To: <m2ob1xba94.fsf@richlowe.net>
On Sun, Feb 23, 2014 at 07:54:47PM -0500, Richard Lowe wrote:
> Bitfields need to specify their signedness explicitly or the compiler is
> free to default as it sees fit. With compilers that default 'unsigned'
> (SUNWspro 12 seems to do this) the tri-state nature of is_binary
> vanishes and all files are treated as binary.
>
> Signed-off-by: Richard Lowe <richlowe@richlowe.net>
Thanks, I wasn't aware of this corner of the standard when I wrote it.
Your fix is obviously correct.
-Peff
next prev parent reply other threads:[~2014-02-24 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 0:54 [PATCH] diffcore.h: be explicit about the signedness of is_binary Richard Lowe
2014-02-24 2:09 ` Jeff King [this message]
2014-02-24 17:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224020940.GB7959@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=richlowe@richlowe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).