From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Siddharth Agarwal <sid0@fb.com>, Vicent Marti <tanoku@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] repack: add `repack.honorpackkeep` config var
Date: Mon, 3 Mar 2014 13:15:58 -0500 [thread overview]
Message-ID: <20140303181558.GA16523@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqeh2jrvz8.fsf@gitster.dls.corp.google.com>
On Mon, Mar 03, 2014 at 10:13:47AM -0800, Junio C Hamano wrote:
> > Or the flip side: if the user wants to use .keep, we should drop
> > bitmaps. My point is that we do not know which way the user wants to
> > go, so we should not tie the options together.
>
> Hmph. I think the short of your later explanation is "global config
> may tell us to use bitmap, in which case we would need a way to
> defeat that and have existing .keep honored, and it makes it easier
> to do so if these two are kept separate, because you do not want to
> run around and selectively disable bitmaps in these repositories.
> We can instead do so with repack.packKeptObjects in the global
> configuration." and I tend to agree with the reasoning.
Yes. Do you need a re-roll from me? I think the last version I sent +
the squash to tie the default to bitmap-writing makes the most sense.
-Peff
next prev parent reply other threads:[~2014-03-03 18:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 2:38 WIth git-next, writing bitmaps fails when keep files are present Siddharth Agarwal
2014-01-23 20:36 ` Siddharth Agarwal
2014-01-23 22:52 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Jeff King
2014-01-23 23:45 ` Siddharth Agarwal
2014-01-23 23:53 ` Siddharth Agarwal
2014-01-24 2:28 ` Jeff King
2014-01-24 2:44 ` Siddharth Agarwal
2014-01-28 6:09 ` [PATCH] repack: add `repack.honorpackkeep` config var Jeff King
2014-01-28 9:21 ` Junio C Hamano
2014-02-24 8:24 ` Jeff King
2014-02-24 19:10 ` Junio C Hamano
2014-02-26 10:13 ` Jeff King
2014-02-26 20:30 ` Junio C Hamano
2014-02-27 11:27 ` Jeff King
2014-02-27 18:04 ` Junio C Hamano
2014-02-28 8:55 ` Jeff King
2014-02-28 17:09 ` Nasser Grainawi
2014-03-01 6:05 ` Jeff King
2014-03-03 19:12 ` Shawn Pearce
2014-02-28 18:45 ` Junio C Hamano
2014-03-01 5:43 ` Jeff King
2014-03-03 18:13 ` Junio C Hamano
2014-03-03 18:15 ` Jeff King [this message]
2014-03-03 19:51 ` Junio C Hamano
2014-03-03 20:04 ` Jeff King
2014-01-23 23:56 ` [PATCH] pack-objects: turn off bitmaps when skipping objects Vicent Martí
2014-01-24 2:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303181558.GA16523@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sid0@fb.com \
--cc=tanoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).