git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Conley Owens <cco3@android.com>, git@vger.kernel.org
Subject: Re: [BUG] Halt during fetch on MacOS
Date: Thu, 6 Mar 2014 16:16:45 -0500	[thread overview]
Message-ID: <20140306211645.GA11926@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqk3c7yyku.fsf@gitster.dls.corp.google.com>

On Thu, Mar 06, 2014 at 10:24:49AM -0800, Junio C Hamano wrote:

> > OK, I've tried using my own build from master, and I still get the same results.
> >
> > I've done a little more investigation and discovered it always hangs at:
> > `atexit(notify_parent);` in `run-command.c:start_command`
> > when running:
> > trace: run_command: 'git-remote-https' 'aosp'
> > 'https://android.googlesource.com/platform/external/tinyxml2'
> >
> > Could this have to do with the atexit implementation?  (eg. limit on
> > the number of functions that can be registered, etc)
> 
> Thanks.
> 
> An interesting theory indeed.  I read that an implementation is
> supposed to take at least ATEXIT_MAX (32) calls to atexit(3); while
> I do think we register functions with atexit(3) from multiple places
> in our code, I doubt we would be making that many.

It seems awfully weird that it would _hang_ in such a case, though. That
sounds more like hitting a mutex that's internal to atexit(), or
something similar.

Conley, can you see if dropping that atexit clears up the problem (you
should be OK without it; git will just fail to notice the child's
exec failure with as much detail).

-Peff

  reply	other threads:[~2014-03-06 21:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 23:26 [BUG] Halt during fetch on MacOS Conley Owens
2014-03-01  6:15 ` Jeff King
2014-03-02  2:02   ` Kyle J. McKay
2014-03-04 22:21     ` Jacopo Notarstefano
2014-03-04  1:03   ` Conley Owens
2014-03-02 14:36 ` Max Horn
2014-03-03 22:50   ` Conley Owens
2014-03-05 21:56 ` Conley Owens
2014-03-06 18:24   ` Junio C Hamano
2014-03-06 21:16     ` Jeff King [this message]
2014-03-06 23:12       ` Conley Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140306211645.GA11926@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=cco3@android.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).