From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Дилян Палаузов" <dilyan.palauzov@aegee.org>,
git@vger.kernel.org, wxs@FreeBSD.org
Subject: Re: [PATCH] configure.ac: link with -liconv for locale_charset()
Date: Wed, 12 Mar 2014 02:39:42 +0400 [thread overview]
Message-ID: <20140311223942.GD11801@hades.panopticon> (raw)
In-Reply-To: <xmqqsiqoo4ma.fsf@gitster.dls.corp.google.com>
* Junio C Hamano (gitster@pobox.com) wrote:
> > On e.g. FreeBSD 10.x, the following situation is common:
> > - there's iconv implementation in libc, which has no locale_charset()
> > function
> > - there's GNU libiconv installed from Ports Collection
> >
> > Git build process
> > - detects that iconv is in libc and thus -liconv is not needed for it
> > - detects locale_charset in -liconv, but for some reason doesn't add it
> > to CHARSET_LIB (as it would do with -lcharset if locale_charset() was
> > found there instead of -liconv)
> > - git doesn't build due to unresolved external locale_charset()
> >
> > Fix this by adding -liconv to CHARSET_LIB if locale_charset() is
> > detected in this library.
> >
> > Signed-off-by: Dmitry Marakasov <amdmi3@amdmi3.ru>
> > ---
>
> Looks sensible; Dilyan, any comments?
Addendum: build logs before and after the fix:
http://people.freebsd.org/~amdmi3/git-iconv-fail.log
http://people.freebsd.org/~amdmi3/git-iconv-fixed.log
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru
next prev parent reply other threads:[~2014-03-11 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 18:35 [PATCH] configure.ac: link with -liconv for locale_charset() Dmitry Marakasov
2014-03-11 20:35 ` Junio C Hamano
2014-03-11 22:37 ` Дилян Палаузов
2014-03-20 21:12 ` Junio C Hamano
2014-03-11 22:39 ` Dmitry Marakasov [this message]
2014-03-12 0:57 ` Dmitry Marakasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311223942.GD11801@hades.panopticon \
--to=amdmi3@amdmi3.ru \
--cc=dilyan.palauzov@aegee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wxs@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).