From: Jeff King <peff@peff.net>
To: Gilles Filippini <gilles.filippini@free.fr>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: [PATCH] subtree: initialize "prefix" variable
Date: Mon, 17 Mar 2014 15:59:47 -0400 [thread overview]
Message-ID: <20140317195946.GA29839@sigill.intra.peff.net> (raw)
In-Reply-To: <5326F158.4050402@free.fr>
On Mon, Mar 17, 2014 at 01:58:00PM +0100, Gilles Filippini wrote:
> Test 21 from contrib/subtree/t/t7900-subtree.sh fails when an
> environment variable 'prefix' is set. For instance here is what happens
> when prefix=/usr:
I think it just needs the patch below.
-- >8 --
We parse the "--prefix" command-line option into the
"$prefix" shell variable. However, if we do not see such an
option, the variable is left with whatever value it had in
the environment. We should initialize it to a known value,
like we do for other variables.
Signed-off-by: Jeff King <peff@peff.net>
---
I checked, and this looks like the only variable in this situation.
contrib/subtree/git-subtree.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
index dc59a91..db925ca 100755
--- a/contrib/subtree/git-subtree.sh
+++ b/contrib/subtree/git-subtree.sh
@@ -46,6 +46,7 @@ ignore_joins=
annotate=
squash=
message=
+prefix=
debug()
{
--
1.9.0.532.gc4c322d
next prev parent reply other threads:[~2014-03-17 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 12:58 [BUG] contrib/subtree: t/t7900-subtree.sh: test 21 fails when environment variable 'prefix' is set Gilles Filippini
2014-03-17 19:59 ` Jeff King [this message]
2014-03-17 20:08 ` [PATCH] subtree: initialize "prefix" variable Eric Sunshine
2014-03-17 20:56 ` Jeff King
2014-03-17 20:44 ` [BUG] contrib/subtree: t/t7900-subtree.sh: test 21 fails when environment variable 'prefix' is set Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317195946.GA29839@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=gilles.filippini@free.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).