From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: David Tran <unsignedzero@gmail.com>, git@vger.kernel.org
Subject: [PATCH 0/12] GIT_CONFIG in the test suite
Date: Thu, 20 Mar 2014 19:11:59 -0400 [thread overview]
Message-ID: <20140320231159.GA7774@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqzjkm3xo1.fsf@gitster.dls.corp.google.com>
On Wed, Mar 19, 2014 at 10:28:46AM -0700, Junio C Hamano wrote:
> [git config --file versus GIT_CONFIG=]
>
> Thanks. Then I think it makes sense to do such a conversion but it
> probably should be done on top of this patch (we could do it before
> this patch), not as a part of this patch.
Here's a series that goes on top of what you queued in
dt/tests-with-env-not-subshell. Once I started cleaning, I noticed a lot
of room for improvement and modernization in t0001. I hope I didn't get
too carried away.
[01/12]: t/Makefile: stop setting GIT_CONFIG
[02/12]: t/test-lib: drop redundant unset of GIT_CONFIG
[03/12]: t: drop useless sane_unset GIT_* calls
[04/12]: t: stop using GIT_CONFIG to cross repo boundaries
[05/12]: t: prefer "git config --file" to GIT_CONFIG with test_must_fail
[06/12]: t: prefer "git config --file" to GIT_CONFIG
[07/12]: t0001: make symlink reinit test more careful
[08/12]: t0001: use test_path_is_*
[09/12]: t0001: use test_config_global
[10/12]: t0001: use test_must_fail
[11/12]: t0001: drop useless subshells
[12/12]: t0001: drop subshells just for "cd"
t/Makefile | 4 +-
t/t0001-init.sh | 211 ++++++++++-------------------------
t/t1300-repo-config.sh | 28 ++---
t/t1302-repo-version.sh | 2 +-
t/t5701-clone-local.sh | 6 +-
t/t7400-submodule-basic.sh | 5 +-
t/t9130-git-svn-authors-file.sh | 3 +-
t/t9154-git-svn-fancy-glob.sh | 6 +-
t/t9400-git-cvsserver-server.sh | 1 -
t/test-lib.sh | 1 -
10 files changed, 87 insertions(+), 180 deletions(-)
-Peff
next prev parent reply other threads:[~2014-03-20 23:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <244284@gmane.comp.version-control.git>
2014-03-18 12:08 ` [PATCH v2] tests: set temp variables using 'env' in test function instead of subshell David Tran
2014-03-18 20:37 ` Junio C Hamano
2014-03-18 21:45 ` Jeff King
2014-03-18 22:16 ` Junio C Hamano
2014-03-18 23:06 ` Jeff King
2014-03-19 17:28 ` Junio C Hamano
2014-03-20 23:11 ` Jeff King [this message]
2014-03-20 23:13 ` [PATCH 01/12] t/Makefile: stop setting GIT_CONFIG Jeff King
2014-03-20 23:13 ` [PATCH 02/12] t/test-lib: drop redundant unset of GIT_CONFIG Jeff King
2014-03-20 23:14 ` [PATCH 03/12] t: drop useless sane_unset GIT_* calls Jeff King
2014-03-21 21:24 ` Junio C Hamano
2014-03-24 21:56 ` Jeff King
2014-03-24 22:06 ` Junio C Hamano
2014-03-25 4:56 ` Junio C Hamano
2014-03-20 23:15 ` [PATCH 04/12] t: stop using GIT_CONFIG to cross repo boundaries Jeff King
2014-03-21 21:26 ` Junio C Hamano
2014-03-24 22:00 ` Jeff King
2014-03-20 23:15 ` [PATCH 05/12] t: prefer "git config --file" to GIT_CONFIG with test_must_fail Jeff King
2014-03-20 23:17 ` [PATCH 06/12] t: prefer "git config --file" to GIT_CONFIG Jeff King
2014-03-20 23:17 ` [PATCH 07/12] t0001: make symlink reinit test more careful Jeff King
2014-03-20 23:17 ` [PATCH 08/12] t0001: use test_path_is_* Jeff King
2014-03-20 23:18 ` [PATCH 09/12] t0001: use test_config_global Jeff King
2014-03-20 23:19 ` [PATCH 10/12] t0001: use test_must_fail Jeff King
2014-03-20 23:21 ` [PATCH 11/12] t0001: drop useless subshells Jeff King
2014-03-21 20:27 ` Eric Sunshine
2014-03-20 23:23 ` [PATCH 12/12] t0001: drop subshells just for "cd" Jeff King
2014-03-18 22:36 ` [PATCH v2] tests: set temp variables using 'env' in test function instead of subshell Eric Sunshine
2014-03-18 20:52 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320231159.GA7774@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=unsignedzero@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).