From: Jeff King <peff@peff.net>
To: David Kastrup <dak@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Bump core.deltaBaseCacheLimit to 128MiB
Date: Thu, 20 Mar 2014 19:48:59 -0400 [thread overview]
Message-ID: <20140320234859.GD7774@sigill.intra.peff.net> (raw)
In-Reply-To: <1395232712-6412-1-git-send-email-dak@gnu.org>
On Wed, Mar 19, 2014 at 01:38:32PM +0100, David Kastrup wrote:
> The default of 16MiB causes serious thrashing for large delta chains
> combined with large files.
Does it make much sense to bump this without also bumping
MAX_DELTA_CACHE in sha1_file.c? In my measurements of linux.git, bumping
the memory limit did not help much without also bumping the number of
slots.
I guess that just bumping the memory limit would help with repos which
have deltas on large-ish files (whereas the kernel just has a lot of
deltas on a lot of little directories), but I'd be curious how much.
If you have before-and-after numbers for just this patch on some
repository, that would be an interesting thing to put in the commit
message.
-Peff
next prev parent reply other threads:[~2014-03-20 23:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 12:38 [PATCH v2] Bump core.deltaBaseCacheLimit to 128MiB David Kastrup
2014-03-19 21:09 ` Junio C Hamano
2014-03-19 21:25 ` David Kastrup
2014-03-19 22:11 ` Junio C Hamano
2014-03-20 1:38 ` Duy Nguyen
2014-03-20 17:02 ` Junio C Hamano
2014-03-20 17:08 ` David Kastrup
2014-03-20 22:35 ` Junio C Hamano
2014-03-21 6:04 ` David Kastrup
2014-03-21 7:59 ` Duy Nguyen
2014-03-21 8:02 ` David Kastrup
2014-03-20 23:48 ` Jeff King [this message]
2014-03-21 6:12 ` David Kastrup
2014-03-21 8:11 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320234859.GD7774@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).