From: Jeff King <peff@peff.net>
To: George Papanikolaou <g3orge.app@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies
Date: Fri, 21 Mar 2014 02:32:15 -0400 [thread overview]
Message-ID: <20140321063215.GA744@sigill.intra.peff.net> (raw)
In-Reply-To: <1395308103-16018-1-git-send-email-g3orge.app@gmail.com>
On Thu, Mar 20, 2014 at 11:35:03AM +0200, George Papanikolaou wrote:
> Hi again guys,
> I forgot to add the signed-of line to the tiny patch I sent earlier for GSOC.
> Any ideas about the changes?
> Thanks...
You don't give any detail on the inefficiencies, or what specific
benchmark is made faster. Have you done any timings to show that there
is a measurable improvement? If so, can you share them in the commit
message?
-Peff
next prev parent reply other threads:[~2014-03-21 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 9:35 [PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies George Papanikolaou
2014-03-21 6:32 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-20 1:32 George Papanikolaou
2014-03-20 9:58 ` Michael Haggerty
2014-03-20 10:58 ` George Papanikolaou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321063215.GA744@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=g3orge.app@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).