From: Jeff King <peff@peff.net>
To: Scott Sandler <scott.m.sandler@gmail.com>
Cc: Nasser Grainawi <nasser@codeaurora.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Git push race condition?
Date: Tue, 25 Mar 2014 10:57:00 -0400 [thread overview]
Message-ID: <20140325145700.GA10132@sigill.intra.peff.net> (raw)
In-Reply-To: <CAAyEjTPtaKExJJSc3yrxVNzx0DmOyeUFH-Uxz3dn0iezqc5VKA@mail.gmail.com>
On Tue, Mar 25, 2014 at 09:45:20AM -0400, Scott Sandler wrote:
> Version of git on the server? git version 1.8.3-rc0
There was significant work done between v1.8.3 and v1.8.4 on handling
races in the ref code. As I said before, I don't think the symptoms you
are describing are anything we have seen, or that could be triggered by
the races we found (which were mostly to do with ref enumeration, not
ref writing). But I would suggest upgrading to a newer version of git as
a precaution.
You mentioned elsewhere turning on the reflog, which I think is a good
idea. If there is a race of this sort, you will see a "hole" in the
reflog, where a ref goes from A->B, then again from A->B' (whereas with
normal writes, it would be B->B').
-Peff
next prev parent reply other threads:[~2014-03-25 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:18 Git push race condition? Scott Sandler
2014-03-24 19:44 ` Matthieu Moy
2014-03-24 20:01 ` Scott Sandler
2014-03-24 22:09 ` Matthieu Moy
2014-03-24 22:44 ` Junio C Hamano
2014-03-24 21:16 ` Ævar Arnfjörð Bjarmason
2014-03-24 21:29 ` Scott Sandler
2014-03-24 22:51 ` Jeff King
2014-03-24 22:54 ` Jeff King
2014-03-24 22:59 ` Nasser Grainawi
2014-03-25 13:45 ` Scott Sandler
2014-03-25 14:03 ` Matthieu Moy
2014-03-25 14:16 ` Scott Sandler
2014-03-25 14:22 ` Matthieu Moy
2014-03-25 14:57 ` Jeff King [this message]
2014-04-10 19:14 ` Scott Sandler
2014-04-11 7:46 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325145700.GA10132@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=nasser@codeaurora.org \
--cc=scott.m.sandler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).