From: Jeff King <peff@peff.net>
To: Maurice Bos <m-ou.se@m-ou.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-prompt.sh: make '+' work for unborn branches
Date: Thu, 27 Mar 2014 19:08:11 -0400 [thread overview]
Message-ID: <20140327230811.GD32434@sigill.intra.peff.net> (raw)
In-Reply-To: <CABbCQwskqZzzRXm5K3dnOfRoAcx8jpsdskngmN7f1EvY6BONgw@mail.gmail.com>
On Thu, Mar 06, 2014 at 10:16:47PM +0100, Maurice Bos wrote:
> I have no clue why git diff --cached isn't used instead of git diff-index.
> I was wondering about it, but I decided I don't know enough about git and
> there are probably valid reasons for doing it this way. Though, replacing
> it with with git diff --cached seems to have the exact same behaviour, as
> far as I tested. That would make the patch a little prettier, as it doesn't
> contain the empty tree id any more:
I think it probably goes in the wrong direction, though. The prompt code
should probably be building on plumbing, not porcelain. So your original
patch as-is is probably the most sensible thing (we may want to convert
the first git-diff call to use plumbing, too, but that would be a
separate patch).
It looks like Junio did not pick up your patch. You may want to repost
it.
-Peff
prev parent reply other threads:[~2014-03-27 23:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 23:05 [PATCH] git-prompt.sh: make '+' work for unborn branches Maurice Bos
[not found] ` <20140306204026.GC29659@sigill.intra.peff.net>
[not found] ` <CABbCQwskqZzzRXm5K3dnOfRoAcx8jpsdskngmN7f1EvY6BONgw@mail.gmail.com>
2014-03-06 21:19 ` Maurice Bos
2014-03-27 23:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327230811.GD32434@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=m-ou.se@m-ou.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).