From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Marat Radchenko <marat@slonopotamus.org>, git@vger.kernel.org
Subject: Re: [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues
Date: Mon, 31 Mar 2014 17:07:14 -0400 [thread overview]
Message-ID: <20140331210714.GA6422@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq4n2e8eov.fsf@gitster.dls.corp.google.com>
On Mon, Mar 31, 2014 at 10:23:44AM -0700, Junio C Hamano wrote:
> SET_PTR() may not be used, but are there places where SET_INT() is
> abused with a cast-to-pointer for the same effect? I didn't check,
> but if there are such places, converting them to use SET_PTR() with
> their existing cast removed may be a better way to go.
Anyone doing that should be beaten with a clue stick.
Fortunately, I grepped through and I did not see any cases. My clue
stick remains untouched.
-Peff
next prev parent reply other threads:[~2014-03-31 21:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 12:04 [PATCH] MSVC: fix t0040-parse-options Marat Radchenko
2014-03-28 18:19 ` Junio C Hamano
2014-03-29 19:59 ` [PATCH v2] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-29 20:09 ` [PATCH v3] " Marat Radchenko
2014-03-29 21:34 ` Andreas Schwab
2014-03-29 22:17 ` René Scharfe
2014-03-30 2:01 ` Junio C Hamano
2014-03-30 8:29 ` Andreas Schwab
2014-03-31 21:09 ` Jeff King
2014-03-30 11:08 ` [PATCH v4 0/3] Take four on fixing OPT_SET_PTR issues Marat Radchenko
2014-03-31 17:23 ` Junio C Hamano
2014-03-31 21:07 ` Jeff King [this message]
2014-03-31 22:54 ` Junio C Hamano
2014-03-30 11:08 ` [PATCH v4 1/3] MSVC: fix t0040-parse-options crash Marat Radchenko
2014-03-30 11:08 ` [PATCH v4 2/3] parse-options: add cast to correct pointer type to OPT_SET_PTR Marat Radchenko
2014-03-31 17:16 ` Junio C Hamano
2014-03-30 11:08 ` [PATCH v4 3/3] parse-options: remove unused OPT_SET_PTR Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331210714.GA6422@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).