git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 4/6] run_external_diff: drop fflush(NULL)
Date: Sat, 19 Apr 2014 15:19:30 -0400	[thread overview]
Message-ID: <20140419191930.GD8981@sigill.intra.peff.net> (raw)
In-Reply-To: <20140419191128.GA9266@sigill.intra.peff.net>

This fflush was added in d5535ec (Use run_command() to spawn
external diff programs instead of fork/exec., 2007-10-19),
because flushing buffers before forking is a good habit.

But later, 7d0b18a (Add output flushing before fork(),
2008-08-04) added it to the generic run-command interface,
meaning that our flush here is redundant.

Signed-off-by: Jeff King <peff@peff.net>
---
 diff.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/diff.c b/diff.c
index b517d01..fdb7f6c 100644
--- a/diff.c
+++ b/diff.c
@@ -2928,7 +2928,6 @@ static void run_external_diff(const char *pgm,
 		argv_array_push(&argv, pgm);
 		argv_array_push(&argv, name);
 	}
-	fflush(NULL);
 
 	argv_array_pushf(&env, "GIT_DIFF_PATH_COUNTER=%d", ++o->diff_path_counter);
 	argv_array_pushf(&env, "GIT_DIFF_PATH_TOTAL=%d", q->nr);
-- 
1.9.1.656.ge8a0637

  parent reply	other threads:[~2014-04-19 19:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-19 19:11 [PATCH 0/6] run_external_diff cleanups Jeff King
2014-04-19 19:17 ` [PATCH 1/6] run_external_diff: use an argv_array for the command line Jeff King
2014-04-19 22:09   ` Max L
2014-04-20  1:35     ` Jeff King
2014-04-20  1:20   ` Eric Sunshine
2014-04-19 19:17 ` [PATCH 2/6] run_external_diff: use an argv_array for the environment Jeff King
2014-04-19 19:19 ` [PATCH 3/6] run_external_diff: clean up error handling Jeff King
2014-04-19 19:19 ` Jeff King [this message]
2014-04-19 19:20 ` [PATCH 5/6] run_external_diff: hoist common bits out of conditional Jeff King
2014-04-19 19:22 ` [PATCH 6/6] run_external_diff: refactor cmdline setup logic Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140419191930.GD8981@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).