git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@logfs.org>
To: git@vger.kernel.org
Subject: [PATCH] Revert "Stop starting pager recursively"
Date: Mon, 21 Apr 2014 16:46:22 -0400	[thread overview]
Message-ID: <20140421204622.GA9532@logfs.org> (raw)

This reverts commit 88e8f908f2b0c56f9ccf8134d8ff9f689af9cc84.

Caused a usability regression for me and foul language for my coworkers.

In particular, I commonly do a "git log", with results going through
less, find a potentially interesting commit and execute "git show
<commit>" from less.  This used to show the patch in less and no longer
does.

Manually typing "git show <commit> | less" works, but is annoying,
wasting time and usually only done after seeing the mess from the simple
invocation.
---
 pager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pager.c b/pager.c
index 0cc75a8eee32..53670a63a7ae 100644
--- a/pager.c
+++ b/pager.c
@@ -64,7 +64,7 @@ void setup_pager(void)
 {
 	const char *pager = git_pager(isatty(1));
 
-	if (!pager || pager_in_use())
+	if (!pager)
 		return;
 
 	/*
-- 
1.9.1

             reply	other threads:[~2014-04-21 21:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 20:46 Jörn Engel [this message]
2014-04-25 18:29 ` [PATCH] Revert "Stop starting pager recursively" Jörn Engel
2014-04-25 18:49   ` Matthieu Moy
2014-04-25 20:10     ` Jörn Engel
2014-04-26  7:13       ` Jeff King
2014-04-26 17:27         ` Junio C Hamano
2014-04-26 17:35           ` Jeff King
2014-04-27  2:12         ` Duy Nguyen
2014-04-27  7:56           ` Jeff King
2014-04-27 15:06             ` Matthieu Moy
     [not found]               ` <xmqqk3a9s7fm.fsf@gitster.dls.corp.google.com>
2014-04-28 18:32                 ` Jörn Engel
2014-04-28 23:04                   ` Junio C Hamano
2014-04-28 23:39                     ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140421204622.GA9532@logfs.org \
    --to=joern@logfs.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).