From: Jeff King <peff@peff.net>
To: Stepan Kasal <kasal@ucw.cz>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org,
Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
Subject: Re: [PATCH v3] git tag --contains: avoid stack overflow
Date: Fri, 25 Apr 2014 01:54:28 -0400 [thread overview]
Message-ID: <20140425055428.GA25337@sigill.intra.peff.net> (raw)
In-Reply-To: <20140424122439.GB8168@camelia.ucw.cz>
On Thu, Apr 24, 2014 at 02:24:39PM +0200, Stepan Kasal wrote:
> From: Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
>
> In large repos, the recursion implementation of contains(commit,
> commit_list) may result in a stack overflow. Replace the recursion with
> a loop to fix it.
>
> This problem is more apparent on Windows than on Linux, where the stack
> is more limited by default.
>
> See also this thread on the msysGit list:
>
> https://groups.google.com/d/topic/msysgit/FqT6boJrb2g/discussion
>
> [jes: re-written to imitate the original recursion more closely]
>
> Thomas Braun pointed out several documentation shortcomings.
>
> Tests are run only if ulimit -s is available. This means they cannot
> be run on Windows.
>
> Signed-off-by: Jean-Jacques Lafay <jeanjacques.lafay@gmail.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Tested-by: Stepan Kasal <kasal@ucw.cz>
Thanks, this version looks good to me.
-Peff
next prev parent reply other threads:[~2014-04-25 5:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:15 [PATCH] git tag --contains : avoid stack overflow Stepan Kasal
2014-04-16 15:46 ` Jeff King
2014-04-17 17:31 ` Johannes Schindelin
2014-04-17 21:32 ` Jeff King
2014-04-17 21:52 ` Johannes Schindelin
2014-04-17 21:58 ` Jeff King
2014-04-23 7:53 ` [PATCH v2] " Stepan Kasal
2014-04-23 14:28 ` Johannes Schindelin
2014-04-23 15:45 ` Stepan Kasal
2014-04-23 19:12 ` Junio C Hamano
2014-04-23 19:16 ` Jeff King
2014-04-23 20:48 ` Junio C Hamano
2014-04-23 20:55 ` Jeff King
2014-04-23 21:05 ` Junio C Hamano
2014-04-24 12:20 ` Stepan Kasal
2014-04-24 12:24 ` [PATCH v3] git tag --contains: " Stepan Kasal
2014-04-25 5:54 ` Jeff King [this message]
2014-09-20 18:18 ` Andreas Schwab
2014-09-23 16:05 ` Jeff King
2014-09-23 21:48 ` Andreas Schwab
2014-09-23 22:41 ` Junio C Hamano
2014-04-23 19:59 ` [PATCH v2] git tag --contains : " Stepan Kasal
2014-04-23 19:17 ` Jeff King
2014-04-23 21:14 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425055428.GA25337@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeanjacques.lafay@gmail.com \
--cc=kasal@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).