From: Stepan Kasal <kasal@ucw.cz>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Theodore Leblond <theodore.leblond@gmail.com>
Subject: [PATCH] poll/select: prevent busy-waiting
Date: Mon, 28 Apr 2014 13:42:24 +0200 [thread overview]
Message-ID: <20140428114224.GA11186@camelia.ucw.cz> (raw)
In-Reply-To: <20140428113815.GA10559@camelia.ucw.cz>
From: Paolo Bonzini <bonzini@gnu.org>
Date: Mon, 21 May 2012 09:52:42 +0200
Backported from Gnulib.
2012-05-21 Paolo Bonzini <bonzini@gnu.org>
poll/select: prevent busy-waiting. SwitchToThread() only gives away
the rest of the current time slice to another thread in the current
process. So if the thread that feeds the file decscriptor we're
polling is not in the current process, we get busy-waiting.
* lib/poll.c: Use SleepEx(1, TRUE) instead of SwitchToThread().
Patch from Theodore Leblond.
* lib/select.c: Split polling out of the loop that sets the output
fd_sets. Check for zero result and loop if the wait timeout is
infinite.
Signed-off-by: Stepan Kasal <kasal@ucw.cz>
---
compat/poll/poll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/poll/poll.c b/compat/poll/poll.c
index 31163f2..a9b41d8 100644
--- a/compat/poll/poll.c
+++ b/compat/poll/poll.c
@@ -605,7 +605,7 @@ restart:
if (!rc && timeout == INFTIM)
{
- SwitchToThread();
+ SleepEx (1, TRUE);
goto restart;
}
--
1.9.2.msysgit.0.158.g6070cee
next prev parent reply other threads:[~2014-04-28 11:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 8:39 [PATCH] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 9:07 ` Erik Faye-Lund
2014-04-28 11:38 ` Stepan Kasal
2014-04-28 11:42 ` Stepan Kasal [this message]
2014-04-28 11:44 ` [PATCH] poll/select: prevent busy-waiting Erik Faye-Lund
2014-04-28 14:29 ` [PATCH] Windows: Always normalize paths to Windows-style Stepan Kasal
2014-04-28 15:26 ` Stepan Kasal
2014-05-07 18:44 ` Heiko Voigt
2014-05-07 20:40 ` Junio C Hamano
2014-05-08 10:11 ` Stepan Kasal
2014-05-08 20:13 ` Junio C Hamano
2014-05-08 20:36 ` [PATCH] Revert "submodules: fix ambiguous absolute paths under Windows" Stepan Kasal
2014-04-28 15:05 ` [PATCH] poll/select: prevent busy-waiting Johannes Sixt
2014-04-28 15:35 ` [PATCH v2] Sleep 1 millisecond in poll() to avoid busy wait Stepan Kasal
2014-04-28 15:37 ` Erik Faye-Lund
2014-04-28 18:58 ` Junio C Hamano
2014-04-29 3:47 ` Stepan Kasal
2014-04-29 16:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428114224.GA11186@camelia.ucw.cz \
--to=kasal@ucw.cz \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=theodore.leblond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).