From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: David Kastrup <dak@gnu.org>,
git@vger.kernel.org, gitster@pobox.com, jrnieder@gmail.com
Subject: Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default
Date: Mon, 28 Apr 2014 12:24:39 -0400 [thread overview]
Message-ID: <20140428162439.GA9844@sigill.intra.peff.net> (raw)
In-Reply-To: <vpq38gxlk3m.fsf@anie.imag.fr>
On Mon, Apr 28, 2014 at 02:22:21PM +0200, Matthieu Moy wrote:
> >> Not since f82c3ffd862c7 (Wed Feb 5 2014, move LESS/LV pager environment
> >> to Makefile).
> >
> > The only upstream branch containing this commit is pu. So this patch
> > should likely not go anywhere else for now.
>
> Oops, indeed, I made my patch on top of pu by mistake. Anyway, my patch
> can wait for the other series to be merged.
>
> Jeff, you're the author of f82c3ffd862c7, topic jk/makefile in git.git,
> marked "expecting a reroll" by Junio. Any news from the series?
I am planning to revisit it eventually, but it's fairly low priority.
There is some pretty heavy refactoring in the series, and the PAGER_ENV
bits do not have to be held hostage to that refactoring (they are really
just demonstrating the refactoring).
I'd be OK with doing the moral equivalent for now (perhaps just taking
Junio's proposal[1]), and I can deal with the refactoring later when
re-rolling the Makefile series.
-Peff
[1] http://article.gmane.org/gmane.comp.version-control.git/240637
next prev parent reply other threads:[~2014-04-28 16:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 23:46 Harmful LESS flags d9ba
2014-04-24 0:11 ` Jonathan Nieder
2014-04-28 21:38 ` Mark Nudelman
2014-04-24 5:06 ` David Kastrup
2014-04-24 19:02 ` Junio C Hamano
2014-04-24 19:21 ` David Kastrup
2014-04-24 19:29 ` Junio C Hamano
2014-04-24 19:50 ` David Kastrup
2014-04-24 21:35 ` Jeff King
2014-04-24 21:47 ` Junio C Hamano
2014-04-24 22:02 ` Jeff King
2014-04-24 21:48 ` David Kastrup
2014-04-24 22:13 ` Jeff King
2014-04-24 22:44 ` David Kastrup
2014-04-24 23:08 ` Jonathan Nieder
2014-04-25 6:56 ` Matthieu Moy
2014-04-25 15:11 ` Jonathan Nieder
2014-04-25 15:32 ` David Kastrup
2014-04-25 15:47 ` Jonathan Nieder
2014-04-28 8:34 ` [PATCH] PAGER_ENV: remove 'S' from $LESS by default Matthieu Moy
2014-04-28 8:43 ` David Kastrup
2014-04-28 8:59 ` Matthieu Moy
2014-04-28 9:14 ` David Kastrup
2014-04-28 12:22 ` Matthieu Moy
2014-04-28 16:24 ` Jeff King [this message]
2014-04-28 18:48 ` Junio C Hamano
2014-04-29 12:29 ` Matthieu Moy
2014-04-29 17:01 ` Junio C Hamano
2014-04-30 7:35 ` [PATCH v2] pager: " Matthieu Moy
2014-04-30 15:38 ` Junio C Hamano
2014-04-30 15:49 ` Matthieu Moy
2014-04-30 17:34 ` Junio C Hamano
2014-05-05 18:44 ` Jonathan Nieder
2014-05-05 20:10 ` Matthieu Moy
2014-05-06 17:34 ` Junio C Hamano
2014-05-06 18:00 ` David Kastrup
2014-05-06 18:49 ` Matthieu Moy
2014-05-06 21:55 ` Jeff King
2014-05-07 17:07 ` Junio C Hamano
2014-05-07 17:54 ` Matthieu Moy
2014-05-07 20:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428162439.GA9844@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).