From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marat Radchenko Subject: Re: [PATCH 07/12] MINGW: config.mak.uname: reorganize MINGW settings Date: Mon, 28 Apr 2014 20:42:02 +0400 Message-ID: <20140428164202.GB19504@seldon> References: <1398693097-24651-1-git-send-email-marat@slonopotamus.org> <1398693097-24651-8-git-send-email-marat@slonopotamus.org> <20140428150436.GB19002@seldon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sebastian Schuberth , GIT Mailing-list , Felipe Contreras To: Erik Faye-Lund X-From: git-owner@vger.kernel.org Mon Apr 28 18:42:24 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WeodM-00057d-23 for gcvg-git-2@plane.gmane.org; Mon, 28 Apr 2014 18:42:24 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756843AbaD1QmK (ORCPT ); Mon, 28 Apr 2014 12:42:10 -0400 Received: from seldon.slonopotamus.org ([94.242.204.247]:57015 "EHLO slonopotamus.org" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755802AbaD1QmG (ORCPT ); Mon, 28 Apr 2014 12:42:06 -0400 Received: from marat by slonopotamus.org with local (Exim 4.80.1) (envelope-from ) id 1Weod0-00057I-HV; Mon, 28 Apr 2014 20:42:02 +0400 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Mon, Apr 28, 2014 at 05:17:25PM +0200, Erik Faye-Lund wrote: > > 1. What are other ways to provide iconv on MinGW? > > I'm not sure I understand. To set HAVE_LIBCHARSET_H, we need to have > libcharset.h. MinGW doesn't supply by default to my knowledge, so we > get it from iconv. The THIS_IS_MSYSGIT file is there for us to be able > to pick the right defaults for msysGit, and us having libcharset is > indeed a msysGit-detail. Not all iconv-flavors supply libcharset.h, so > this tells a particularity about the one we have in msysGit. > > 2. One can still completely disable iconv with NO_ICONV=1 > > Sure. And it does seem like the current setup assumes that anyone > building for MinGW has iconv. But perhaps that's a mistake? This patch assumes that "if user has iconv under MinGW, he has libcharset.h". Without it, we assume "if user has iconv under MinGW, he has langinfo.h". If user doesn't have iconv, he needs to say this via NO_ICONV=1 in both cases. Anyway, if it is a questionable change, I'll drop it and only keep NO_R_TO_GCC_LINKER change. > To be honest, I think the whole THIS_IS_MSYSGIT-block should have > stayed downstream. That's a completely different story.