From: Jeff King <peff@peff.net>
To: Dan Albert <danalbert@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Uses git-credential for git-imap-send
Date: Mon, 28 Apr 2014 23:05:34 -0400 [thread overview]
Message-ID: <20140429030534.GA12118@sigill.intra.peff.net> (raw)
In-Reply-To: <c3bb0fb7f87e6ada5c73923b14d66c743a76caa6.1398739667.git.danalbert@google.com>
On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote:
> > I noticed that we are just filling in the password here, since we'll
> > always fill cred.username from srvc->user. The lines directly above are:
> >
> > if (!srvc->user) {
> > fprintf(stderr, "Skipping server %s, no user\n", srvc->host);
> > goto bail;
> > }
> >
> > That comes from the imap.user config variable. I wonder if we should
> > just pass it off to credential_fill() in this case, too, which will fill
> > in the username if necessary.
> [...]
>
> Yeah, doubtful anyone cares, but it's simple enough to do.
Thanks, I think the result looks good.
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2014-04-29 3:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 17:50 [PATCH] Uses git-credential for git-imap-send Dan Albert
2014-04-26 18:08 ` Jeff King
[not found] ` <CAFVaGhuXvZhRCHRFurKNOC4tsiQ7WZnGb2CbRnoSSYg=XknJtg@mail.gmail.com>
2014-04-27 7:51 ` Jeff King
2014-04-27 17:58 ` Dan Albert
2014-04-28 19:23 ` Jeff King
2014-04-29 3:00 ` Dan Albert
2014-04-29 3:05 ` Jeff King [this message]
2014-04-29 17:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429030534.GA12118@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=danalbert@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).