From: Jonathan Nieder <jrnieder@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Define constants for lengths of object names
Date: Thu, 1 May 2014 11:23:04 -0700 [thread overview]
Message-ID: <20140501182304.GB9218@google.com> (raw)
In-Reply-To: <20140501172007.GZ9218@google.com>
Jonathan Nieder wrote:
> brian m. carlson wrote:
>> --- a/object.h
>> +++ b/object.h
> [...]
>> @@ -49,7 +56,7 @@ struct object {
>> unsigned used : 1;
>> unsigned type : TYPE_BITS;
>> unsigned flags : FLAG_BITS;
>> - unsigned char sha1[20];
>> + unsigned char sha1[GIT_OID_RAWSZ];
>
> Maybe my brain has been damaged by reading code from too many C
> projects that hard-code some constants, but I find '20' easier to read
> here.
That said, RAW_SHA1_BYTES would sound okay to me.
Part of the problem was how long it takes to mentally parse oid_rawsz.
Thanks,
Jonathan
next prev parent reply other threads:[~2014-05-01 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 11:06 [PATCH] Define constants for lengths of object names brian m. carlson
2014-05-01 17:20 ` Jonathan Nieder
2014-05-01 18:23 ` Jonathan Nieder [this message]
2014-05-01 23:00 ` brian m. carlson
2014-05-01 23:05 ` Jonathan Nieder
2014-05-02 0:15 ` Duy Nguyen
2014-05-02 22:09 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140501182304.GB9218@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).