From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: [PATCH 0/4] approxidate for "git commit --date=foo"
Date: Thu, 1 May 2014 21:03:28 -0400 [thread overview]
Message-ID: <20140502010328.GA30556@sigill.intra.peff.net> (raw)
In-Reply-To: <20140501220639.GD14441@sigill.intra.peff.net>
On Thu, May 01, 2014 at 06:06:39PM -0400, Jeff King wrote:
> > I think the original rationale was that it's OK for us to allow some
> > sloppiness when _viewing_ commits, since you will generally notice the
> > problem. But when making commits, it's better to be careful, since you
> > may be setting the sha1 in stone.
> >
> > These days we have two tools that could help:
> >
> > 1. approxidate_careful will do a regular approxidate, but keep track
> > of whether we found anything even remotely useful. That doesn't mean
> > you can't still get unexpected results, but at least some truly
> > useless cases return errors.
> >
> > 2. For commits with a different author and committer, we mention the
> > author name in the post-commit summary. We could do the same with a
> > timestamp that was given (i.e., mentioning it in a standard format)
> > to give the user another opportunity to double-check what we parsed.
>
> I think it would make sense if we followed both of those points.
Here are patches to do so.
[1/4]: commit: use split_ident_line to compare author/committer
[2/4]: pretty: make show_ident_date public
[3/4]: commit: print "Date" line when the user has set date
[4/4]: commit: accept more date formats for "--date"
-Peff
next prev parent reply other threads:[~2014-05-02 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 21:09 [RFD] use approxidate for "git commit --date=xyz"? Linus Torvalds
2014-04-30 21:34 ` Junio C Hamano
2014-05-01 22:06 ` Jeff King
2014-05-02 1:03 ` Jeff King [this message]
2014-05-02 1:06 ` [PATCH 1/4] commit: use split_ident_line to compare author/committer Jeff King
2014-05-02 1:07 ` [PATCH 2/4] pretty: make show_ident_date public Jeff King
2014-05-02 1:10 ` [PATCH 3/4] commit: print "Date" line when the user has set date Jeff King
2014-05-02 1:12 ` [PATCH 4/4] commit: accept more date formats for "--date" Jeff King
2014-05-07 7:22 ` [RFD] use approxidate for "git commit --date=xyz"? Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502010328.GA30556@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).