From: Charles Bailey <cbailey32@bloomberg.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Detect endianness on more platforms that don't use BYTE_ORDER
Date: Fri, 2 May 2014 17:58:30 +0100 [thread overview]
Message-ID: <20140502165830.GA29339@hashpling.org> (raw)
In-Reply-To: <xmqqwqe4azyd.fsf@gitster.dls.corp.google.com>
On Fri, May 02, 2014 at 09:48:58AM -0700, Junio C Hamano wrote:
> Charles Bailey <cbailey32@bloomberg.net> writes:
>
> > ---
>
> Please sign-off your patches ;-)
Oops! Please consider this patch...
Signed-off-by: Charles Bailey <cbailey32@bloomberg.net>
> This swaps the precedence of BYTE_ORDER and __BYTE_ORDER from the
> original, which we may not want to. It is easy for me to swap the
> order of if/elif to restore it, so it is not a big deal, though.
I think I swapped the precedence (semi-deliberately) because I found a
proposal to standardize the BYTE_ORDER variant. I claim that any
platform which provides both but with differing senses is somewhat
broken so I cannot see the precedence mattering much. I don't mind
either way.
Charles.
next prev parent reply other threads:[~2014-05-02 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 7:43 [PATCH] Add extra logic required to detect endianness on Solaris Charles Bailey
2014-05-01 18:58 ` Junio C Hamano
2014-05-01 19:18 ` Junio C Hamano
2014-05-01 19:22 ` Junio C Hamano
2014-05-02 7:49 ` Charles Bailey
2014-05-02 7:55 ` [PATCH] Detect endianness on more platforms that don't use BYTE_ORDER Charles Bailey
2014-05-02 16:48 ` Junio C Hamano
2014-05-02 16:58 ` Charles Bailey [this message]
2014-05-02 19:34 ` Junio C Hamano
2014-05-02 19:43 ` Junio C Hamano
2014-05-02 20:02 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502165830.GA29339@hashpling.org \
--to=cbailey32@bloomberg.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).