From: Jeff King <peff@peff.net>
To: James Denholm <nod.helm@gmail.com>
Cc: git@vger.kernel.org, greend@obbligato.org, apenwarr@gmail.com,
gpmcgee@gmail.com, mmogilvi_git@miniinfo.net
Subject: Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass
Date: Mon, 5 May 2014 01:08:04 -0400 [thread overview]
Message-ID: <20140505050803.GA6569@sigill.intra.peff.net> (raw)
In-Reply-To: <1399121375-14727-1-git-send-email-nod.helm@gmail.com>
On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:
> The main issues are that calls are made to git itself in the build
> process, and that a subtree-exclusive variable is used for specifying
> the exec path. Patches 1/5 through 3/5 resolve these.
>
> The "cleanup" fixes (4/5 and 5/5) are based on precedents set by other
> makefiles across the project.
Thanks, these all look sane to me (I do not use subtree, but since it's
just about Makefiles, it was pretty easy to review).
> One problem is foreseen: 3/5 will necessitate that package maintainers
> who already have git-subtree included in their packages update their
> build-scripts.
I think that's probably OK. We strive for backwards compatibility in the
tool itself, but refactoring Makefiles in contrib/ affects a pretty
limited audience.
-Peff
next prev parent reply other threads:[~2014-05-06 16:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 12:49 [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass James Denholm
2014-05-03 12:49 ` [PATCH v2 1/5] contrib/subtree/Makefile: scrap unused $(gitdir) James Denholm
2014-05-03 12:49 ` [PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE James Denholm
2014-05-03 12:49 ` [PATCH v2 3/5] contrib/subtree/Makefile: s/libexecdir/gitexecdir James Denholm
2014-05-03 12:49 ` [PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup James Denholm
2014-05-03 12:49 ` [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup James Denholm
2014-05-05 5:09 ` Jeff King
2014-05-05 21:41 ` James Denholm
2014-05-05 21:49 ` Jeff King
2014-05-05 21:59 ` James Denholm
2014-05-05 5:08 ` Jeff King [this message]
2014-05-05 21:54 ` [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass James Denholm
2014-05-05 22:01 ` Jeff King
2014-05-06 12:41 ` James Denholm
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 12:41 James Denholm
2014-05-06 21:17 ` Junio C Hamano
2014-05-06 21:46 ` James Denholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505050803.GA6569@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gpmcgee@gmail.com \
--cc=greend@obbligato.org \
--cc=mmogilvi_git@miniinfo.net \
--cc=nod.helm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).