From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "make error()'s constant return value more visible"
Date: Mon, 5 May 2014 02:02:02 -0400 [thread overview]
Message-ID: <20140505060202.GA27360@sigill.intra.peff.net> (raw)
In-Reply-To: <5367257a857ce_2db613a731043@nysa.notmuch>
On Mon, May 05, 2014 at 12:45:30AM -0500, Felipe Contreras wrote:
> Jeff King wrote:
> > On Sun, May 04, 2014 at 01:12:53AM -0500, Felipe Contreras wrote:
> >
> > > So it looks like gcc is smarter now, and in trying to fix a few warnings
> > > we generated hundreds more.
> > >
> > > This reverts commit e208f9cc7574f5980faba498d0aa30b4defeb34f.
> >
> > And now we've gone the other way, and re-enabled the initial warnings.
> > Can we come up with a solution that helps both cases?
>
> What initial warnings? As I explained already I don't get any warnings
> with this patch series in gcc 4.9.0.
The "few warnings" in your statement quoted above.
You could try reading the commit message of the commit you are
reverting, which explains it, but the short answer is: try compiling
with -O3.
-Peff
next prev parent reply other threads:[~2014-05-06 16:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 6:12 [PATCH 0/3] Fix a ton of compiler warnings Felipe Contreras
2014-05-04 6:12 ` [PATCH 1/3] Revert "make error()'s constant return value more visible" Felipe Contreras
2014-05-05 5:49 ` Jeff King
2014-05-05 5:45 ` Felipe Contreras
2014-05-05 6:02 ` Jeff King [this message]
2014-05-05 6:14 ` Felipe Contreras
2014-05-05 6:29 ` Jeff King
2014-05-05 7:30 ` Felipe Contreras
2014-05-05 21:29 ` Jeff King
2014-05-06 15:14 ` [PATCH 1/2] inline constant return from error() function Jeff King
2014-05-06 22:29 ` Junio C Hamano
2014-05-07 3:02 ` Jeff King
2014-05-11 17:22 ` Junio C Hamano
2014-05-12 18:13 ` Jeff King
2014-05-11 7:13 ` Felipe Contreras
2014-05-12 18:44 ` Jonathan Nieder
2014-05-12 18:56 ` Jeff King
2014-05-06 15:17 ` [PATCH 2/2] let clang use the constant-return error() macro Jeff King
2014-05-04 6:12 ` [PATCH 2/3] Revert "silence some -Wuninitialized false positives" Felipe Contreras
2014-05-04 6:12 ` [PATCH 3/3] Silence a bunch of format-zero-length warnings Felipe Contreras
2014-05-04 19:01 ` brian m. carlson
2014-05-04 20:13 ` Felipe Contreras
2014-05-05 5:21 ` Jeff King
2014-05-07 18:19 ` Junio C Hamano
2014-05-07 20:05 ` Heiko Voigt
2014-05-07 20:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505060202.GA27360@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).