From: Pete Wyckoff <pw@padd.com>
To: tolga ceylan <tolga.ceylan@gmail.com>
Cc: git@vger.kernel.org, cdleonard@gmail.com
Subject: Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches
Date: Mon, 5 May 2014 09:14:56 -0400 [thread overview]
Message-ID: <20140505131456.GA21505@padd.com> (raw)
In-Reply-To: <53648169.7010307@gmail.com>
tolga.ceylan@gmail.com wrote on Fri, 02 May 2014 22:40 -0700:
>
> >
> >This is the error message git-apply emits in this case:
> >
> >error: cannot apply binary patch to '<filename>' without full index line
> >error: <filename>: patch does not apply
> >
> >Cheers,
> >Tolga
>
> Any feedback is appreciated.
Sorry, travel delay. This explanation is pretty
straight-forward, thanks.
Suggest you include it in the commit message along with the
other text you had, and resend to the list, cc me and junio.
Oh, and include an ack:
Acked-by: Pete Wyckoff <pw@padd.com>
next prev parent reply other threads:[~2014-05-06 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 4:46 [PATCH] git-p4: format-patch to diff-tree change breaks binary patches Tolga Ceylan
2014-04-26 12:43 ` Pete Wyckoff
2014-04-26 21:12 ` tolga ceylan
2014-04-26 21:31 ` tolga ceylan
2014-05-03 5:40 ` tolga ceylan
2014-05-05 13:14 ` Pete Wyckoff [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-07 5:48 Tolga Ceylan
2014-05-07 17:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505131456.GA21505@padd.com \
--to=pw@padd.com \
--cc=cdleonard@gmail.com \
--cc=git@vger.kernel.org \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).