From: Jeff King <peff@peff.net>
To: James Denholm <nod.helm@gmail.com>
Cc: git@vger.kernel.org, greened@obbligato.org, apenwarr@gmail.com,
gpmcgee@gmail.com, mmogilvi_git@miniinfo.net
Subject: Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass
Date: Mon, 5 May 2014 18:01:12 -0400 [thread overview]
Message-ID: <20140505220112.GA17610@sigill.intra.peff.net> (raw)
In-Reply-To: <69f827ea-0ba2-4ca0-b711-002e1a0010b7@email.android.com>
[fixed David's address in cc list]
On Tue, May 06, 2014 at 07:54:30AM +1000, James Denholm wrote:
> Given that subtree subtree doesn't really generate a lot of discussion,
> would it be advisable to wrap this up (barring further discussion) and send
> it off to Junio rather than waiting for further community consensus?
I do not know if "lack of discussion" is a good reason to consider
something in good shape; oftentimes it is a sign that nobody is
interested in the area. We usually rely on "area maintainers" to give an
OK to the patches if they are not something that the maintainer himself
has an interest in.
However, in this case, you did get review, and I think it is pretty easy
to see the patches are good even if one does not care about the
particular area. So I think they are fine to pass on and apply.
Note also that patches like this are a great place to get started, as
they help build trust in a contributor, who can later help out with
area maintenance.
-Peff
next prev parent reply other threads:[~2014-05-06 16:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 12:49 [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass James Denholm
2014-05-03 12:49 ` [PATCH v2 1/5] contrib/subtree/Makefile: scrap unused $(gitdir) James Denholm
2014-05-03 12:49 ` [PATCH v2 2/5] contrib/subtree/Makefile: Use GIT-VERSION-FILE James Denholm
2014-05-03 12:49 ` [PATCH v2 3/5] contrib/subtree/Makefile: s/libexecdir/gitexecdir James Denholm
2014-05-03 12:49 ` [PATCH v2 4/5] contrib/subtree/Makefile: Doc-gen rules cleanup James Denholm
2014-05-03 12:49 ` [PATCH v2 5/5] contrib/subtree/Makefile: clean rule cleanup James Denholm
2014-05-05 5:09 ` Jeff King
2014-05-05 21:41 ` James Denholm
2014-05-05 21:49 ` Jeff King
2014-05-05 21:59 ` James Denholm
2014-05-05 5:08 ` [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass Jeff King
2014-05-05 21:54 ` James Denholm
2014-05-05 22:01 ` Jeff King [this message]
2014-05-06 12:41 ` James Denholm
-- strict thread matches above, loose matches on Subject: below --
2014-05-06 12:41 James Denholm
2014-05-06 21:17 ` Junio C Hamano
2014-05-06 21:46 ` James Denholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505220112.GA17610@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gpmcgee@gmail.com \
--cc=greened@obbligato.org \
--cc=mmogilvi_git@miniinfo.net \
--cc=nod.helm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).