From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v1 12/25] contrib: remove 'vim'
Date: Thu, 8 May 2014 19:23:50 -0700 [thread overview]
Message-ID: <20140509022350.GH9218@google.com> (raw)
In-Reply-To: <20140509020205.GC9787@sigill.intra.peff.net>
Hi,
Jeff King wrote:
> However, I would certainly agree that that period of time is probably
> over; the scripts started shipping in upstream vim in mid-2008. I'd be
> happy to see this directory go away whether or not the rest of contrib/
> is dropped.
RHEL 6 has vim 7.2.something, so yeah, this should be mostly safe.
Git needs to keep working for people stuck on RHEL 5, but niceties
like vim support seem less important there. But I am not convinced it
is worth inconveniencing them (or putting any obstacles in the way of
upgrading) without a good reason, and one less directory in contrib/
does not seem like a very strong reason.
Here's a new commit message in case we want to do this.
-- >8 --
Subject: contrib: remove vim support instructions
The git support scripts started shipping in upstream vim in version
7.2 (2008-08-09). Clean up contrib/ a little by removing the
instructions for people on older versions of vim.
RHEL 6 already has vim 7.2.something, so anyone on a reasonably modern
operating system should not be affected. Users on RHEL 5 presumably
know that means sometimes missing out on niceties like syntax
highlighting, so this should be safe.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
contrib/vim/README | 22 ----------------------
1 file changed, 22 deletions(-)
delete mode 100644 contrib/vim/README
diff --git a/contrib/vim/README b/contrib/vim/README
deleted file mode 100644
index 8f16d06..0000000
--- a/contrib/vim/README
+++ /dev/null
@@ -1,22 +0,0 @@
-Syntax highlighting for git commit messages, config files, etc. is
-included with the vim distribution as of vim 7.2, and should work
-automatically.
-
-If you have an older version of vim, you can get the latest syntax
-files from the vim project:
-
- http://ftp.vim.org/pub/vim/runtime/syntax/git.vim
- http://ftp.vim.org/pub/vim/runtime/syntax/gitcommit.vim
- http://ftp.vim.org/pub/vim/runtime/syntax/gitconfig.vim
- http://ftp.vim.org/pub/vim/runtime/syntax/gitrebase.vim
- http://ftp.vim.org/pub/vim/runtime/syntax/gitsendemail.vim
-
-These files are also available via FTP at the same location.
-
-To install:
-
- 1. Copy these files to vim's syntax directory $HOME/.vim/syntax
- 2. To auto-detect the editing of various git-related filetypes:
-
- $ curl http://ftp.vim.org/pub/vim/runtime/filetype.vim |
- sed -ne '/^" Git$/, /^$/ p' >>$HOME/.vim/filetype.vim
--
1.9.1.423.g4596e3a
next prev parent reply other threads:[~2014-05-09 2:23 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 0:58 [PATCH v1 00/25] contrib: cleanup Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 02/25] contrib: remove 'hg-to-git' Felipe Contreras
2014-05-09 6:44 ` Miklos Vajna
2014-05-09 0:58 ` [PATCH v1 03/25] contrib: remove 'stats' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 04/25] contrib: remove 'buildsystems' Felipe Contreras
2014-05-09 7:53 ` Erik Faye-Lund
2014-05-09 8:14 ` Felipe Contreras
2014-05-09 8:33 ` Erik Faye-Lund
2014-05-09 8:48 ` Felipe Contreras
2014-05-09 9:10 ` Erik Faye-Lund
2014-05-09 9:32 ` Felipe Contreras
2014-05-09 10:02 ` Erik Faye-Lund
2014-05-09 10:57 ` Felipe Contreras
2014-05-09 11:35 ` Erik Faye-Lund
2014-05-09 9:17 ` David Kastrup
2014-05-09 9:35 ` Felipe Contreras
2014-05-09 9:44 ` David Kastrup
2014-05-09 10:50 ` Felipe Contreras
2014-05-09 11:21 ` David Kastrup
2014-05-09 18:33 ` Jonathan Nieder
2014-05-09 0:58 ` [PATCH v1 05/25] contrib: remove 'convert-objects' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 06/25] contrib: remove 'diffall' Felipe Contreras
2014-05-09 15:12 ` Tim Henigan
2014-05-09 18:50 ` Jonathan Nieder
2014-05-09 19:26 ` Tim Henigan
2014-05-09 20:12 ` Jonathan Nieder
2014-05-09 20:16 ` Tim Henigan
[not found] ` <CAFouetj=30Wd_CDiXA0UqqKNdfJSv+C5mWbMJPOkEdqxr7k54w@mail.gmail.com>
2014-05-09 15:20 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 07/25] contrib: remove 'git-jump' Felipe Contreras
2014-05-09 2:03 ` Jeff King
2014-05-09 2:12 ` Felipe Contreras
2014-05-09 15:20 ` Jeff King
2014-05-09 16:13 ` Felipe Contreras
2014-05-09 17:37 ` Junio C Hamano
2014-05-09 0:58 ` [PATCH v1 08/25] contrib: remove 'git-shell-commands' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 09/25] contrib: remove 'gitview' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 10/25] contrib: reomve 'thunderbird-patch-inline' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 11/25] contrib: remove 'workdir' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 12/25] contrib: remove 'vim' Felipe Contreras
2014-05-09 2:02 ` Jeff King
2014-05-09 2:23 ` Jonathan Nieder [this message]
2014-05-09 0:58 ` [PATCH v1 13/25] contrib: remove 'svn-fe' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 14/25] contrib: remove 'rerere-train' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 15/25] contrib: remove 'remotes2config' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 16/25] contrib: remove 'persistent-https' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 17/25] contrib: remove 'git-resurrect' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 18/25] contrib: remove 'emacs' Felipe Contreras
[not found] ` <CAFcZeCqbF54-KjHU1R3pC6XgWi21KcpRGB7HcbfSGyvTScQU2A@mail.gmail.com>
2014-05-09 8:29 ` Felipe Contreras
[not found] ` <CAFcZeCo5mCfnUN1uBiaZnD6DL6y8hPhK5MPts5raLCTGwJX9Gg@mail.gmail.com>
2014-05-09 8:50 ` Felipe Contreras
2014-05-09 14:50 ` Alexandre Julliard
2014-05-09 14:53 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 19/25] contrib: remove 'diff-highlight' Felipe Contreras
2014-05-09 1:51 ` Jeff King
2014-05-09 1:55 ` Felipe Contreras
2014-05-09 13:37 ` Stefan Beller
2014-05-09 14:16 ` Felipe Contreras
2014-05-09 17:04 ` Junio C Hamano
2014-05-09 17:45 ` Felipe Contreras
2014-05-09 18:06 ` Junio C Hamano
2014-05-09 18:21 ` Felipe Contreras
2014-05-09 18:29 ` Junio C Hamano
2014-05-09 18:40 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 20/25] contrib: remove 'contacts' Felipe Contreras
2014-05-10 1:59 ` brian m. carlson
2014-05-10 4:00 ` Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 22/25] contrib: remove 'fast-import' Felipe Contreras
2014-05-09 0:58 ` [PATCH v1 24/25] contrib: remove 'hooks' Felipe Contreras
2014-05-09 1:47 ` [PATCH v1 00/25] contrib: cleanup Martin Langhoff
[not found] ` <CACPiFCJnsu3qw59oK94sP1u0+KBDvne0ZpKS0LMGc_9ge+rJjA@mail.gmail.com>
2014-05-09 2:01 ` Felipe Contreras
2014-05-09 13:15 ` Stefan Beller
2014-05-09 15:22 ` Jeff King
2014-05-09 15:57 ` Felipe Contreras
2014-05-09 17:09 ` Martin Langhoff
2014-05-09 17:15 ` Felipe Contreras
[not found] ` <1399597116-1851-26-git-send-email-felipe.contreras@gmail.com>
2014-05-09 10:46 ` [PATCH v1 25/25] contrib: remove 'mw-to-git' Matthieu Moy
2014-05-09 10:59 ` Felipe Contreras
2014-05-09 12:30 ` Stefan Beller
[not found] ` <1399597116-1851-24-git-send-email-felipe.contreras@gmail.com>
2014-05-09 15:00 ` [PATCH v1 23/25] contrib: remove 'hooks/multimail' Michael Haggerty
2014-05-09 15:04 ` David Kastrup
2014-05-09 15:28 ` Michael Haggerty
2014-05-09 15:18 ` Felipe Contreras
2014-05-09 16:46 ` James Denholm
2014-05-09 19:56 ` [PATCH v1 00/25] contrib: cleanup Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509022350.GH9218@google.com \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).