[Bug] git-email: sendemail.bcc in config file overrides command line option "--bcc"

[Bug] git-email: sendemail.bcc in config file overrides command line option "--bcc"

[Adam Lee]

BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747068

"--bcc" should have higher priority than sendemail.bcc.

> --bcc=<address>
>     Specify a "Bcc:" value for each email. Default is the value of sendemail.bcc.
>
>     The --bcc option must be repeated for each user you want on the bcc list.

Reproducing steps:
1, set sendemail.bcc in .gitconfig.
2, git send-email --bcc with another address.

-- 
Adam Lee

Re: [Bug] git-email: sendemail.bcc in config file overrides command line option "--bcc"

[Jeff King]

On Fri, May 09, 2014 at 04:13:31PM +0800, Adam Lee wrote:

> BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747068
> 
> "--bcc" should have higher priority than sendemail.bcc.
> 
> > --bcc=<address>
> >     Specify a "Bcc:" value for each email. Default is the value of sendemail.bcc.
> >
> >     The --bcc option must be repeated for each user you want on the bcc list.
> 
> Reproducing steps:
> 1, set sendemail.bcc in .gitconfig.
> 2, git send-email --bcc with another address.

Hrm, I cannot reproduce at all here:

  $ git config sendemail.bcc config-bcc@example.com
  $ git send-email --dry-run --to=to@example.com -1 origin
  (mbox) Adding cc: Junio C Hamano <gitster@pobox.com> from line 'From: Junio C Hamano <gitster@pobox.com>'
  Dry-OK. Log says:
  Sendmail: /usr/sbin/sendmail -i to@example.com gitster@pobox.com config-bcc@example.com
  > [...]

OK, so our configured bcc works. Now let's override it:

  $ git send-email --dry-run --to=to@example.com \
      --bcc=cmdline-bcc@example.com -1 origin
  (mbox) Adding cc: Junio C Hamano <gitster@pobox.com> from line 'From: Junio C Hamano <gitster@pobox.com>'
  Dry-OK. Log says:
  Sendmail: /usr/sbin/sendmail -i to@example.com gitster@pobox.com cmdline-bcc@example.com

That looks like it's working as expected. Can you show us similar
commands that demonstrate the failure?

-Peff

[Closed] git-email: sendemail.bcc in config file overrides command line option "--bcc"

[Adam Lee]

On Fri, May 09, 2014 at 11:45:09AM -0400, Jeff King wrote:
> On Fri, May 09, 2014 at 04:13:31PM +0800, Adam Lee wrote:
> 
> > BugLink: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747068
> > 
> > "--bcc" should have higher priority than sendemail.bcc.
> > 
> > > --bcc=<address>
> > >     Specify a "Bcc:" value for each email. Default is the value of sendemail.bcc.
> > >
> > >     The --bcc option must be repeated for each user you want on the bcc list.
> > 
> > Reproducing steps:
> > 1, set sendemail.bcc in .gitconfig.
> > 2, git send-email --bcc with another address.
> 
> Hrm, I cannot reproduce at all here:
> 
>   $ git config sendemail.bcc config-bcc@example.com
>   $ git send-email --dry-run --to=to@example.com -1 origin
>   (mbox) Adding cc: Junio C Hamano <gitster@pobox.com> from line 'From: Junio C Hamano <gitster@pobox.com>'
>   Dry-OK. Log says:
>   Sendmail: /usr/sbin/sendmail -i to@example.com gitster@pobox.com config-bcc@example.com
>   > [...]
> 
> OK, so our configured bcc works. Now let's override it:
> 
>   $ git send-email --dry-run --to=to@example.com \
>       --bcc=cmdline-bcc@example.com -1 origin
>   (mbox) Adding cc: Junio C Hamano <gitster@pobox.com> from line 'From: Junio C Hamano <gitster@pobox.com>'
>   Dry-OK. Log says:
>   Sendmail: /usr/sbin/sendmail -i to@example.com gitster@pobox.com cmdline-bcc@example.com
> 
> That looks like it's working as expected. Can you show us similar
> commands that demonstrate the failure?
> 
> -Peff

I can't reproduce it now, there might be something wrong in my command
lines, let's close it first. Thanks, Jeff.

-- 
Adam Lee