From: Max Kirillov <max@max630.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [BUGFIX/RFC] git-show: fix 'git show -s' to not add extra terminator after merge commit
Date: Tue, 13 May 2014 02:26:25 +0300 [thread overview]
Message-ID: <20140512232600.GA6857@wheezy.local> (raw)
In-Reply-To: <xmqqk39qu96o.fsf@gitster.dls.corp.google.com>
On Mon, May 12, 2014 at 09:59:39AM -0700, Junio C Hamano wrote:
> A good way to double-check may be to see the fixes to the tests to
> correct their wrong expectations, and if the updated expectation is
> sensible.
I have sent the fixes to tests. To me they look sensible.
Also fixed the things you pointed out.
--
Max
prev parent reply other threads:[~2014-05-12 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 23:25 [BUGFIX/RFC] git-show: fix 'git show -s' to not add extra terminator after merge commit Max Kirillov
2014-05-12 16:59 ` Junio C Hamano
2014-05-12 23:26 ` Max Kirillov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512232600.GA6857@wheezy.local \
--to=max@max630.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).