From: Stepan Kasal <kasal@ucw.cz>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
msysgit@googlegroups.com
Subject: [PATCH 0/2] wincred makefile changes
Date: Tue, 13 May 2014 07:59:53 +0200 [thread overview]
Message-ID: <20140513055953.GA28182@camelia.ucw.cz> (raw)
In-Reply-To: <CABPQNSafKXDLyBj5OYW-PPWdxfxQtC23vKQsQ-_Pa1empU=n8g@mail.gmail.com>
Hello again,
I revisited a patch that is present in msysgit since Oct 2012.
Dropping the cosmetic changes, there are two separate parts:
Pat Thoyts (2):
wincred: add install target
wincred: avoid overwriting configured variables
wincred: add install target
Git for Windows does contain git-credential-wincred
wincred: avoid overwriting configured variables
Generally, overriding these variables this deep is evil.
(We could use ?= if really necessary.)
Erik, does this iteration look better?
Stepan
contrib/credential/wincred/Makefile | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
--
1.9.2.msysgit.0.161.g83227c1
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-05-13 5:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 6:46 [PATCH] wincred: add install target and avoid overwriting configured variables Stepan Kasal
2014-04-30 9:21 ` Erik Faye-Lund
2014-04-30 11:27 ` Stepan Kasal
2014-04-30 11:56 ` Erik Faye-Lund
2014-05-13 5:59 ` Stepan Kasal [this message]
2014-05-13 6:01 ` [PATCH 1/2] wincred: add install target Stepan Kasal
2014-05-13 6:01 ` [PATCH 2/2] wincred: avoid overwriting configured variables Stepan Kasal
2014-05-13 6:34 ` Erik Faye-Lund
2014-05-13 6:53 ` Stepan Kasal
[not found] ` <CABPQNSbb-rdTjCDYoC7uApfcMH8Q0Y-w4Tm9UiN6PhEeD-Gv6Q@mail.gmail.com>
[not found] ` <20140514084509.GA3134@camelia.ucw.cz>
2014-05-14 8:49 ` Erik Faye-Lund
2014-05-13 13:18 ` Felipe Contreras
2014-05-13 13:53 ` Stepan Kasal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513055953.GA28182@camelia.ucw.cz \
--to=kasal@ucw.cz \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).