Re: [GUILT v2 29/29] Added a short style guide, and Emacs settings.

[Jeff Sipek <jeffpc@josefsipek.net>]

On Tue, May 13, 2014 at 10:31:05PM +0200, Per Cederqvist wrote:
> Signed-off-by: Per Cederqvist <cederp@opera.com>
> ---
>  .dir-locals.el             |  3 +++
>  Documentation/Contributing | 15 +++++++++++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 .dir-locals.el
> 
> diff --git a/.dir-locals.el b/.dir-locals.el
> new file mode 100644
> index 0000000..50ef2b7
> --- /dev/null
> +++ b/.dir-locals.el
> @@ -0,0 +1,3 @@
> +((nil . ((indent-tabs-mode . t)
> +	 (tab-width . 8)))
> + (sh-mode . ((sh-basic-offset . 8))))

I'll have to trust you on this one.  All I see is a bunch of cons cells :)

> diff --git a/Documentation/Contributing b/Documentation/Contributing
> index abf3480..0da49d6 100644
> --- a/Documentation/Contributing
> +++ b/Documentation/Contributing
> @@ -4,6 +4,21 @@ Documentation/SubmittingPatches file. :)
>  
>  1) Hack on the code a bit
>  
> +Please follow this style guide:
> +
> + - Use tabs for indentation.
> +
> + - Put "then" on the same line as "if".
> +
> + - Follow the style of the existing code, except if it breaks the
> +   above guidlines.
> +
> + - If you change the code to conform to the style guide, please do so
> +   in a separate commit that does not change anything else.
> +
> +Please check that you change does not break "make test".  Please add
> +new testcases for any new functionality, and if you fix a bug.
> +

Adding this blurb here is a good idea.  Thanks!

Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>

>  2) Make a patch:
>  
>  Use "diff -up" or "diff -uprN" to create patches. Or simply use git to
> -- 
> 1.8.3.1
> 

-- 
Evolution, n.:
  A hypothetical process whereby infinitely improbable events occur with
  alarming frequency, order arises from chaos, and no one is given credit.