From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Fabio D'Alfonso <fabio.dalfonso@fabiodalfonso.com>, git@vger.kernel.org
Subject: Re: t5539 fails on ubuntu for v2.0.0-rc2
Date: Wed, 14 May 2014 06:14:40 -0400 [thread overview]
Message-ID: <20140514101440.GA10173@sigill.intra.peff.net> (raw)
In-Reply-To: <20140510140259.GA6836@sigill.intra.peff.net>
On Sat, May 10, 2014 at 10:02:59AM -0400, Jeff King wrote:
> On Fri, May 09, 2014 at 02:08:27PM -0700, Junio C Hamano wrote:
>
> > > 3. Just disable the http tests when run as root.
> > >
> > > I think I'd favor 3. But I'd like to be sure that being root is the
> > > problem.
> >
> > I agree with both the conclusion and the precondition.
>
> Here's the patch.
>
> The problem starts in v1.9.2, not in v2.0.0, so it's not technically a
> regression in this cycle. And we are awfully late in the -rc period. But
> it is just a change in the test script, and one that seems rather
> unlikely to produce unexpected side effects. I'll leave it you whether
> you want to queue it for v2.0.0, or for the next maint release.
Hrm, sorry, I was wrong about this. I had thought the
auto-network-testing had gone into v1.9.2, but it didn't. So this _is_ a
potential regression in v2.0.0. It's still relatively minor, affecting
only the test suite, so it can probably wait for post-v2.0.0 if you
don't want to do another -rc.
-Peff
next prev parent reply other threads:[~2014-05-14 10:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 19:56 t5539 fails on ubuntu for v2.0.0-rc2 Fabio D'Alfonso
2014-05-07 21:45 ` Junio C Hamano
2014-05-08 4:14 ` Jeff King
2014-05-08 6:02 ` Fabio D'Alfonso
2014-05-08 14:13 ` Fabio D'Alfonso
2014-05-09 15:59 ` Jeff King
2014-05-09 16:43 ` Fabio D'Alfonso
2014-05-09 21:08 ` Junio C Hamano
2014-05-10 14:02 ` Jeff King
2014-05-14 10:14 ` Jeff King [this message]
2014-05-14 17:11 ` Junio C Hamano
2014-05-14 19:33 ` Jeff King
2014-05-08 21:36 ` t5539 fails on ubuntu for v2.0.0-rc2 - the SAME on 12.04 server Fabio D'Alfonso
2014-05-09 8:39 ` t5539 fails on ubuntu for v2.0.0-rc2 - the SAME on 12.04 server - this test was disabled up to 1.9.2 Fabio D'Alfonso
2014-05-09 15:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514101440.GA10173@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=fabio.dalfonso@fabiodalfonso.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).