From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
Stepan Kasal <kasal@ucw.cz>,
GIT Mailing-list <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option
Date: Thu, 15 May 2014 10:56:14 -0700 [thread overview]
Message-ID: <20140515175614.GN9218@google.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1405151944410.14982@s15462909.onlinehome-server.info>
Johannes Schindelin wrote:
> On Wed, 14 May 2014, Jeff King wrote:
>> We've already found the lines of interest to the user. It would be nice
>> if we could somehow point the pager at them by number, rather than
>> repeating the (slightly incompatible) search.
>
> FWIW it is exactly that type of "I want your patch to do more than you do"
> type of comments that makes it impossible for myself to contribute patches
> anymore.
I think you're overreacting to Peff's "It would be nice".
It is a way of talking about where this lies in a design space that
also includes the git-jump tool that Peff worked on. Maybe the tools
can learn from each other. It is not a reason not to apply the patch.
Jonathan
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-05-15 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:50 [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option Stepan Kasal
2014-05-14 17:57 ` Junio C Hamano
2014-05-14 18:15 ` Matthieu Moy
2014-05-14 18:26 ` Jonathan Nieder
2014-05-14 18:33 ` Junio C Hamano
2014-05-15 17:44 ` Johannes Schindelin
2014-05-15 17:53 ` Jonathan Nieder
2014-05-15 19:01 ` Johannes Schindelin
2014-05-15 19:48 ` Junio C Hamano
2014-05-14 18:35 ` Stepan Kasal
2014-05-14 19:07 ` Jeff King
2014-05-15 17:46 ` Johannes Schindelin
2014-05-15 17:56 ` Jonathan Nieder [this message]
2014-05-15 19:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515175614.GN9218@google.com \
--to=jrnieder@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kasal@ucw.cz \
--cc=msysgit@googlegroups.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).