From: Jeff King <peff@peff.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 07/10] replace: die early if replace ref already exists
Date: Sat, 17 May 2014 03:05:18 -0400 [thread overview]
Message-ID: <20140517070518.GD13003@sigill.intra.peff.net> (raw)
In-Reply-To: <20140517064133.18932.92343.chriscool@tuxfamily.org>
On Sat, May 17, 2014 at 08:41:29AM +0200, Christian Couder wrote:
> If a replace ref already exists for an object, it is
> much better for the user if we error out before we
> let the user edit the object, rather than after.
Definitely. Code looks fine to me.
-Peff
next prev parent reply other threads:[~2014-05-17 7:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 6:41 [PATCH v2 00/10] replace: add option to edit a Git object Christian Couder
2014-05-17 6:41 ` [PATCH v2 01/10] replace: refactor command-mode determination Christian Couder
2014-05-17 6:41 ` [PATCH v2 02/10] replace: use OPT_CMDMODE to handle modes Christian Couder
2014-05-17 6:41 ` [PATCH v2 03/10] replace: factor object resolution out of replace_object Christian Couder
2014-05-17 6:41 ` [PATCH v2 04/10] replace: add --edit option Christian Couder
2014-05-17 6:41 ` [PATCH v2 05/10] replace: make sure --edit results in a different object Christian Couder
2014-05-17 7:03 ` Jeff King
2014-05-17 6:41 ` [PATCH v2 06/10] replace: refactor checking ref validity Christian Couder
2014-05-17 6:41 ` [PATCH v2 07/10] replace: die early if replace ref already exists Christian Couder
2014-05-17 7:05 ` Jeff King [this message]
2014-05-17 6:41 ` [PATCH v2 08/10] replace: add tests for --edit Christian Couder
2014-05-17 7:14 ` Jeff King
2014-05-17 6:41 ` [PATCH v2 09/10] replace: add --edit to usage string Christian Couder
2014-05-17 6:41 ` [PATCH v2 10/10] Documentation: replace: describe new --edit option Christian Couder
2014-05-17 7:23 ` Jeff King
2014-05-17 7:24 ` [PATCH v2 00/10] replace: add option to edit a Git object Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140517070518.GD13003@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).