From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Couder Subject: [PATCH v3 07/10] replace: die early if replace ref already exists Date: Sat, 17 May 2014 14:16:36 +0200 Message-ID: <20140517121640.27582.63595.chriscool@tuxfamily.org> References: <20140517120649.27582.58609.chriscool@tuxfamily.org> Cc: git@vger.kernel.org, Jeff King To: Junio C Hamano X-From: git-owner@vger.kernel.org Sat May 17 17:58:42 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wlh0Q-0003Xp-KE for gcvg-git-2@plane.gmane.org; Sat, 17 May 2014 17:58:38 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488AbaEQP6R (ORCPT ); Sat, 17 May 2014 11:58:17 -0400 Received: from mail-2y.bbox.fr ([194.158.98.15]:44491 "EHLO mail-2y.bbox.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757437AbaEQP5k (ORCPT ); Sat, 17 May 2014 11:57:40 -0400 Received: from [127.0.1.1] (cha92-h01-128-78-31-246.dsl.sta.abo.bbox.fr [128.78.31.246]) by mail-2y.bbox.fr (Postfix) with ESMTP id 41FA049; Sat, 17 May 2014 17:57:39 +0200 (CEST) X-git-sha1: f83b0912ea8d664d3649c47722362238dab176c7 X-Mailer: git-mail-commits v0.5.2 In-Reply-To: <20140517120649.27582.58609.chriscool@tuxfamily.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: If a replace ref already exists for an object, it is much better for the user if we error out before we let the user edit the object, rather than after. Signed-off-by: Christian Couder --- builtin/replace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/builtin/replace.c b/builtin/replace.c index 3d6edaf..4ee3d92 100644 --- a/builtin/replace.c +++ b/builtin/replace.c @@ -268,7 +268,8 @@ static int edit_and_replace(const char *object_ref, int force) { char *tmpfile = git_pathdup("REPLACE_EDITOBJ"); enum object_type type; - unsigned char old[20], new[20]; + unsigned char old[20], new[20], prev[20]; + char ref[PATH_MAX]; if (get_sha1(object_ref, old) < 0) die("Not a valid object name: '%s'", object_ref); @@ -277,6 +278,8 @@ static int edit_and_replace(const char *object_ref, int force) if (type < 0) die("unable to get object type for %s", sha1_to_hex(old)); + check_ref_valid(old, prev, ref, sizeof(ref), force); + export_object(old, tmpfile); if (launch_editor(tmpfile, NULL, NULL) < 0) die("editing object file failed"); -- 1.9.rc0.17.g651113e