From: Jonathan Nieder <jrnieder@gmail.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/19] convert test -a/-o to && and || patch series
Date: Tue, 20 May 2014 11:22:36 -0700 [thread overview]
Message-ID: <20140520182236.GQ12314@google.com> (raw)
In-Reply-To: <1400593832-6510-1-git-send-email-gitter.spiros@gmail.com>
Hi,
Elia Pinto wrote:
> These patch series convert test -a/-o to && and ||.
Should this come with a new check in t/check-non-portable-shell.pl so
we don't regress in the future?
> Elia Pinto (19):
[...]
> check_bindir | 2 +-
> contrib/examples/git-clone.sh | 2 +-
> contrib/examples/git-commit.sh | 4 ++--
> contrib/examples/git-merge.sh | 4 ++--
> contrib/examples/git-repack.sh | 4 ++--
> contrib/examples/git-resolve.sh | 2 +-
> git-bisect.sh | 2 +-
> git-mergetool.sh | 4 ++--
> git-rebase--interactive.sh | 2 +-
> git-submodule.sh | 29 +++++++++++++++++------------
> t/t0025-crlf-auto.sh | 6 +++---
> t/t0026-eol-config.sh | 8 ++++----
> t/t4102-apply-rename.sh | 2 +-
> t/t5000-tar-tree.sh | 2 +-
> t/t5403-post-checkout-hook.sh | 8 ++++----
> t/t5537-fetch-shallow.sh | 2 +-
> t/t5538-push-shallow.sh | 2 +-
> t/t9814-git-p4-rename.sh | 4 ++--
> t/test-lib-functions.sh | 4 ++--
> 19 files changed, 49 insertions(+), 44 deletions(-)
I still think one patch per file is too many patches for this. It would
be easier to read with, e.g., whichever ones were most complex as
separate patches and the rest (the "easy" ones) as a single patch.
Thanks,
Jonathan
prev parent reply other threads:[~2014-05-20 18:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 13:50 [PATCH 00/19] convert test -a/-o to && and || patch series Elia Pinto
2014-05-20 13:50 ` [PATCH 01/19] check_bindir: convert test -a/-o to && and || Elia Pinto
2014-05-20 18:12 ` Junio C Hamano
2014-05-20 18:54 ` Junio C Hamano
2014-05-20 13:50 ` [PATCH 02/19] contrib/examples/git-clone.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 03/19] contrib/examples/git-commit.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 04/19] contrib/examples/git-merge.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 05/19] contrib/examples/git-repack.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 06/19] contrib/examples/git-resolve.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 07/19] git-bisect.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 08/19] git-mergetool.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 09/19] git-rebase--interactive.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 10/19] git-submodule.sh: " Elia Pinto
2014-05-20 14:07 ` Matthieu Moy
2014-05-20 14:39 ` Johannes Sixt
2014-05-20 13:50 ` [PATCH 11/19] t/t0025-crlf-auto.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 12/19] t/t0026-eol-config.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 13/19] t/t4102-apply-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 14/19] t/t5000-tar-tree.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 15/19] t/t5403-post-checkout-hook.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 16/19] t/t5537-fetch-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 17/19] t/t5538-push-shallow.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 18/19] t/t9814-git-p4-rename.sh: " Elia Pinto
2014-05-20 13:50 ` [PATCH 19/19] t/test-lib-functions.sh: " Elia Pinto
2014-05-20 14:09 ` [PATCH 00/19] convert test -a/-o to && and || patch series Matthieu Moy
2014-05-20 17:57 ` Junio C Hamano
2014-05-20 18:22 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520182236.GQ12314@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).