git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Sergei Organov <osv@javad.com>
Cc: git@vger.kernel.org
Subject: Re: Slight inconsistency between ref delete commands.
Date: Wed, 21 May 2014 12:49:41 -0400	[thread overview]
Message-ID: <20140521164941.GB2040@sigill.intra.peff.net> (raw)
In-Reply-To: <871tvn5shp.fsf@osv.gnss.ru>

On Wed, May 21, 2014 at 02:35:46PM +0400, Sergei Organov wrote:

> Was writing conversion script from CVS to git for my repo and noticed
> slight inconsistency in git-tag, git-branch, and git-update-ref behavior:
> 
> $ git --version
> git version 1.9.3
> $ git tag -d && echo success
> success

This makes sense to me. "tag -d" takes zero or more tags and deletes
them.

> $ git branch -d && echo success
> fatal: branch name required

Here I think "branch -d" is being overly picky. It should behave the
same as tag. I'd welcome a patch for that.

> $ git update-ref -d && echo success

Here we cannot do the same "zero or more" behavior, because of:

> usage: git update-ref [options] -d <refname> [<oldval>]

...we need to be able to take an optional "<oldval>" for each argument.

> Noticed when used xargs without -r switch, like this:
> 
> git for-each-ref --format="%(refname)" "refs/tags/*-merge" | xargs -n 1 git update-ref -d

I know this is a side note to the inconsistency you found, but it would
be nice to be able to do that with a single update-ref invocation. Not
only for simplicity, but also because it would be more efficient
(deleting a packed ref has to rewrite the whole packed-refs file; we can
get away with one rewrite if we know we are deleting multiple refs).

Recently-ish, update-ref learned a "--stdin" mode, which I think you
could use like:

  git for-each-ref --format='delete %(refname)' refs/tags/*-merge |
  git update-ref --stdin

-Peff

      reply	other threads:[~2014-05-21 16:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 10:35 Slight inconsistency between ref delete commands Sergei Organov
2014-05-21 16:49 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521164941.GB2040@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=osv@javad.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).