From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeremiah Mahler <jmmahler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v5] format-patch --signature-file <file>
Date: Wed, 21 May 2014 13:59:30 -0400 [thread overview]
Message-ID: <20140521175930.GA4588@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqq61kzqbi6.fsf@gitster.dls.corp.google.com>
On Wed, May 21, 2014 at 10:37:05AM -0700, Junio C Hamano wrote:
> > I wasn't planning on anything as drastic as stripspace. I really just
> > wanted to suppress the one newline, which is almost certainly the right
> > thing to include for "--signature", but the wrong thing for
> > "--signature-file" (i.e., the patch I posted earlier).
> > ...
> > I dunno. Maybe it is not worth caring too much about.
>
> I suggested stripspace() because I know we do not care too
> much, actually.
>
> Cleansing blank lines in one way for many types of user input
> (e.g. commit log messages and tag messages) while doing it in a
> completely different way just for "--signature-file" is warranted if
> there is a good reason for them to be different, but I did not think
> of any, and I still don't. So...
I didn't think of mine as cleansing. It is more like "do not duplicate a
newline ourselves if there is already one there". But I guess those are
two sides of the same coin.
-Peff
next prev parent reply other threads:[~2014-05-21 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 8:00 [PATCH v5] format-patch --signature-file <file> Jeremiah Mahler
2014-05-20 8:00 ` Jeremiah Mahler
2014-05-20 8:27 ` Jeff King
2014-05-20 17:53 ` Junio C Hamano
2014-05-20 18:24 ` Jeff King
2014-05-20 18:46 ` Junio C Hamano
2014-05-21 16:42 ` Jeff King
2014-05-21 16:55 ` Jeremiah Mahler
2014-05-21 17:00 ` Jeff King
2014-05-21 17:37 ` Junio C Hamano
2014-05-21 17:59 ` Jeff King [this message]
2014-05-21 18:26 ` Junio C Hamano
2014-05-21 20:47 ` Jeff King
2014-05-21 21:14 ` Jeremiah Mahler
2014-05-21 0:42 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521175930.GA4588@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jmmahler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).