From: Jeff King <peff@peff.net>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] config: respect '~' and '~user' in mailmap.file
Date: Tue, 27 May 2014 12:09:39 -0400 [thread overview]
Message-ID: <20140527160939.GA29693@sigill.intra.peff.net> (raw)
In-Reply-To: <1401180358-27281-1-git-send-email-oystwa@gmail.com>
On Tue, May 27, 2014 at 10:45:58AM +0200, Øystein Walle wrote:
> git_config_string() does not handle '~' and '~user' as part of the
> value. Using git_config_pathname() fixes this.
Makes sense. Curious if there was a reason we did not use it in the
first place, I looked at the history. The reason is that mailmap.file
was added in d551a48 (2009-02-08) and git_config_pathname came months
later in 395de25 (2009-11-17). Retro-fitting it now should not cause a
problem for any sane paths. So:
Reviewed-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2014-05-27 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 8:45 [PATCH] config: respect '~' and '~user' in mailmap.file Øystein Walle
2014-05-27 16:09 ` Jeff King [this message]
2014-05-27 23:28 ` Øystein Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527160939.GA29693@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).